You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Sandy Ryza (JIRA)" <ji...@apache.org> on 2012/10/24 00:36:12 UTC

[jira] [Created] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs.

Sandy Ryza created YARN-184:
-------------------------------

             Summary: Remove unnecessary locking in fair scheduler, and address findbugs.
                 Key: YARN-184
                 URL: https://issues.apache.org/jira/browse/YARN-184
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Sandy Ryza
            Assignee: Sandy Ryza


In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497270#comment-13497270 ] 

Sandy Ryza commented on YARN-184:
---------------------------------

Made the changes and posted a new patch
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Attachment: YARN-184.patch
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Attachment: YARN-184-1.patch
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496862#comment-13496862 ] 

Hadoop QA commented on YARN-184:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553426/YARN-184-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/145//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/145//console

This message is automatically generated.
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499606#comment-13499606 ] 

Hadoop QA commented on YARN-184:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553927/YARN-184-3.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/153//console

This message is automatically generated.
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499607#comment-13499607 ] 

Hudson commented on YARN-184:
-----------------------------

Integrated in Hadoop-trunk-Commit #3040 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3040/])
    YARN-184. Remove unnecessary locking in fair scheduler, and address findbugs excludes. (sandyr via tucu) (Revision 1410826)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410826
Files : 
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java

                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496873#comment-13496873 ] 

Alejandro Abdelnur commented on YARN-184:
-----------------------------------------

*FairScheduler.java*

* The UpdateThread should be set as a daemon thread.

*QueueManager.java*

* At the end of the  reloadAllocs() method a synchronized block on THIS reassigns all resources info/apps/weights/modes/.. values. But the getter methods of those values are not synchronized, ie getUserMaxApp() which could lead to an inconsistent result. A solution would be to have a struct that defines all the instance Maps, make that volatile, assign it atomically and on the getter methods assign it to a local var and then access all its values from the local var (if a reassign happens half way you still have a consistent view of all values you use)

                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499792#comment-13499792 ] 

Hudson commented on YARN-184:
-----------------------------

Integrated in Hadoop-Hdfs-trunk #1230 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1230/])
    YARN-184. Remove unnecessary locking in fair scheduler, and address findbugs excludes. (sandyr via tucu) (Revision 1410826)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410826
Files : 
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java

                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Attachment: YARN-184-3.patch
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Summary: Remove unnecessary locking in fair scheduler, and address findbugs excludes.  (was: Remove unnecessary locking in fair scheduler, and address findbugs.)
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Attachment: YARN-184-2.patch
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498289#comment-13498289 ] 

Sandy Ryza commented on YARN-184:
---------------------------------

Putting the QueueManager assignment in reinitialize would either require a findbugs exclude or synchronizing all accesses to it, which seems unnecessary because its value never changes after creation.

I'll update the comment. [~tucu00] is there anything else you'd like me to change?
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499352#comment-13499352 ] 

Alejandro Abdelnur commented on YARN-184:
-----------------------------------------

Sandy, looks good except for something I've missed in my previous review. In the QueueManager,

{code}
  public Collection<FSQueue> getQueues() {
    synchronized (queues) {
      return queues.values();
    }
  }
{code}

The returned collection should be a copy of queues.values() as the returned collection is not threadsafe.


                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandy Ryza updated YARN-184:
----------------------------

    Attachment: YARN-184-3.patch
    
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Sandy Ryza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496747#comment-13496747 ] 

Sandy Ryza commented on YARN-184:
---------------------------------

After some discussion with Karthik, I made changes to remove the remaining findbugs excludes, and posted a new patch.
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498263#comment-13498263 ] 

Karthik Kambatla commented on YARN-184:
---------------------------------------

Thanks for the patch, Sandy. The patch looks mostly ready, I had the following minor comments:

# It might be better to lazily instantiate QueueManager - say before the corresponding initialize()
# Do you want to rephrase the comment preceding getAppWeight()? I don't think the synchronization there is redundant, the method is synchronized to access sizeBasedWeight consistently (holding same locks) across all accesses? Comments?
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499349#comment-13499349 ] 

Hadoop QA commented on YARN-184:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553517/YARN-184-2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/152//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/152//console

This message is automatically generated.
                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-184) Remove unnecessary locking in fair scheduler, and address findbugs excludes.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499800#comment-13499800 ] 

Hudson commented on YARN-184:
-----------------------------

Integrated in Hadoop-Mapreduce-trunk #1261 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1261/])
    YARN-184. Remove unnecessary locking in fair scheduler, and address findbugs excludes. (sandyr via tucu) (Revision 1410826)

     Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410826
Files : 
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java

                
> Remove unnecessary locking in fair scheduler, and address findbugs excludes.
> ----------------------------------------------------------------------------
>
>                 Key: YARN-184
>                 URL: https://issues.apache.org/jira/browse/YARN-184
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184-3.patch, YARN-184-3.patch, YARN-184.patch
>
>
> In YARN-12, locks were added to all fields of QueueManager to address findbugs.  In addition, findbugs exclusions were added in response to MAPREDUCE-4439, without a deep look at the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira