[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8305: [SQL Lab] Improve autocomplete

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8305: [SQL Lab] Improve autocomplete
URL: https://github.com/apache/incubator-superset/pull/8305#discussion_r330140552
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
 ##########
 @@ -27,6 +27,11 @@ import { areArraysShallowEqual } from '../../reduxUtils';
 
 const langTools = ace.acequire('ace/ext/language_tools');
 
+const SQL_KEYWORD_AUTOCOMPLETE_SCORE = 100;
 
 Review comment:
   They're used by ace editor's autocomplete logic to determine the ordering of autocomplete results

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org