You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/09/24 11:36:39 UTC
[PR] Record the first and last token of CREATE statements for their spans [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2571:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2571
Twenty-four `CREATE` statements had an empty span, among them `CREATE FUNCTION`, `CREATE TYPE`, `CREATE SCHEMA`, `CREATE USER` and the Snowflake stage and warehouse forms. They now store their first and last token, set in `Parser::parse_statement` like the `DROP` statements. The last token skips an `EOF` or `;` that some of these parsers consume while looking for optional clauses. The span check skips its edge-token comparison for `CREATE FUNCTION`, `CREATE ROLE` and `CREATE OPERATOR CLASS`, whose renderings reorder or drop clauses. The span baseline loses 450 lines and gains none.
Part of #1548.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Spans: CREATE statements [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 closed pull request #2571: Spans: CREATE statements
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Record the first and last token of CREATE statements for their spans [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2571:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2571#issuecomment-5813369108
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `98.64865%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 85.28%. Comparing base ([`789fb99`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/789fb99f0f6283773bfd64fd996adf9cb57cd87e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`db4aaaa`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/db4aaaa3f44c86abeb7160b17a5066f80e3fad73?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/parser/mod.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?src=pr&el=tree&filepath=src%2Fparser%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3BhcnNlci9tb2QucnM=) | 98.41% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/test\_utils/span\_oracle.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?src=pr&el=tree&filepath=src%2Ftest_utils%2Fspan_oracle.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3Rlc3RfdXRpbHMvc3Bhbl9vcmFjbGUucnM=) | 96.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## span-drop-statements #2571 +/- ##
========================================================
+ Coverage 85.20% 85.28% +0.07%
========================================================
Files 43 43
Lines 34233 34428 +195
Branches 34233 34428 +195
========================================================
+ Hits 29169 29361 +192
Misses 1592 1592
- Partials 3472 3475 +3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2571?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org