You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/07/05 23:16:40 UTC
[GitHub] [accumulo] EdColeman commented on a diff in pull request #3568: Change Wait.waitFor to throw IllegalStateException
EdColeman commented on code in PR #3568:
URL: https://github.com/apache/accumulo/pull/3568#discussion_r1253745537
##########
test/src/main/java/org/apache/accumulo/test/shell/ShellServerIT.java:
##########
@@ -520,10 +520,12 @@ public void setIterOptionPrompt() throws Exception {
protected void checkTableForProperty(final AccumuloClient client, final String tableName,
final String expectedKey, final String expectedValue) throws Exception {
- assertTrue(
- Wait.waitFor(() -> client.tableOperations().getConfiguration(tableName).get(expectedKey)
- .equals(expectedValue), 5000, 500),
- "Failed to find expected value for key: " + expectedKey);
+ try {
Review Comment:
This one place had an exception message that I thought would be nice to keep - all other occurrences where just failing when they used assertTrue and there were some that did not test the return condition.
Keeping the exception message in this single case if its not adding much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org