You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2023/04/20 03:08:13 UTC
[GitHub] [incubator-paimon] liugddx opened a new issue, #950: [Improve] Unified command line parameters
liugddx opened a new issue, #950:
URL: https://github.com/apache/incubator-paimon/issues/950
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/incubator-paimon/issues) and found nothing similar.
### Motivation
1. Use jcommander to unify console parameters
2. Remove duplicate code
3. Optimized help tips
### Solution
_No response_
### Anything else?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515670254
@JingsongLi Do we need this part of the optimization? For example, partition configuration partition=key1=value1,key2=value2. Now we can use partition=key1=value1 key2=value2, there is also no need to parse it separately in the code, just need this ``` @DynamicParameter(
names = {"--partition"},
description = "partition key value pair, for example key1=value1 key2=value2")
private Map<String, String> partition;```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515770644
3. At present, the definition of usage is manually written, which is more detailed but also brings maintenance complexity. We can automatically generate usage through jcommander. Of course, jcommander also provides the ability to customize usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx closed issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx closed issue #950: [Improve] Unified command line parameters
URL: https://github.com/apache/incubator-paimon/issues/950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx closed issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx closed issue #950: [Improve] Unified command line parameters
URL: https://github.com/apache/incubator-paimon/issues/950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515766189
At present, the command line parameters are scattered in the method
This is deceptive. We can define parameters as parameters of action, like
<img width="939" alt="ef99be7a10c7d634fdb0135719a1484" src="https://user-images.githubusercontent.com/48236177/233273276-ab5ff77f-abdd-451b-b53d-c3ce05c92dd3.png">
this is more maintenance-friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1516142911
> I think this is a good improvement, but I don't think our Actions are so complicated. I think we can use this later, in the event of a problem occurring, there is no apparent problem at this time
I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515771619
@JingsongLi @SteNicholas Can you give me some advice. I'd be happy to parameterize this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on issue #950: [Improve] Unified command line parameters
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515896915
I think this is a good improvement, but I don't think our Actions are so complicated.
I think we can use this later, in the event of a problem occurring, there is no apparent problem at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] liugddx commented on issue #950: [Improve] Unified command line parameters
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on issue #950:
URL: https://github.com/apache/incubator-paimon/issues/950#issuecomment-1515761501
At present, there will be no friendly prompts for parsing parameter exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org