You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/15 19:29:03 UTC

[GitHub] [arrow-rs] iajoiner opened a new pull request, #2734: Update version to `23.0.0` and update `CHANGELOG`

iajoiner opened a new pull request, #2734:
URL: https://github.com/apache/arrow-rs/pull/2734

   # Which issue does this PR close?
   
   Closes #2665.
   
   # Rationale for this change
   Prepare for biweekly release
   
   # What changes are included in this PR?
   
   # Are there any user-facing changes?
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] iajoiner commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`

Posted by GitBox <gi...@apache.org>.
iajoiner commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1248523527

   @andygrove @alamb Looks like we can start to automatically generate pull requests and issues using the GitHub APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] iajoiner commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
iajoiner commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1249480361

   @alamb I think we can modify the script and either an argument or detect whether `CHANGELOG-old.md` is already up-to-date. I prefer the latter and will make the changes next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1249565356

   Benchmark runs are scheduled for baseline = 968a7673c7e1341431bc4d55a4f50e9fa6aff7d5 and contender = 1da2bfbc82de12ac6fb699d2579d4a129929e004. 1da2bfbc82de12ac6fb699d2579d4a129929e004 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/58618bdea0e14a5babcf672168fc4908...415ac7725add4cbb92d00f6d4462e812/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9f74912e12684f0881b169402c999780...db7a75c5feaa4959b68a3760fbb4e368/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/057024c821ec457aa4071610c1d92221...d6409d1d309347c8a523533c62338ada/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/89cfe7b08a2b41bf88cb71631bd3b413...b298c405c1504bf6b0d4c61b594aa5d9/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a diff in pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#discussion_r973098700


##########
dev/release/label_issues.py:
##########
@@ -0,0 +1,151 @@
+##############################################################################

Review Comment:
   FYI @iajoiner  -- here is my hacky python script to update github labels 
   
   It does appear to work... But is definitely a bit of a hack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] iajoiner commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`

Posted by GitBox <gi...@apache.org>.
iajoiner commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1248530009

   @alamb Thanks! I will file the PR for the release PR generation script now and then another one for the issue generation script by Monday. The amount of repetitive human work for releases should be further minimized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1248527090

   Thanks @iajoiner  -- I am working on a script for https://github.com/apache/arrow-rs/issues/2727 now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a diff in pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#discussion_r973190318


##########
CHANGELOG.md:
##########
@@ -19,119 +19,108 @@
 
 # Changelog
 
-## [22.0.0](https://github.com/apache/arrow-rs/tree/22.0.0) (2022-09-02)
+## [23.0.0](https://github.com/apache/arrow-rs/tree/23.0.0) (2022-09-16)
 
-[Full Changelog](https://github.com/apache/arrow-rs/compare/21.0.0...22.0.0)
+[Full Changelog](https://github.com/apache/arrow-rs/compare/22.0.0...23.0.0)
 
 **Breaking changes:**
 
-- Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag [\#2614](https://github.com/apache/arrow-rs/pull/2614) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([viirya](https://github.com/viirya))
-- Gate dyn comparison of dictionary arrays behind `dyn_cmp_dict` [\#2597](https://github.com/apache/arrow-rs/pull/2597) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([tustvold](https://github.com/tustvold))
-- Move JsonSerializable to json module \(\#2300\) [\#2595](https://github.com/apache/arrow-rs/pull/2595) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([tustvold](https://github.com/tustvold))
-- Decimal precision scale datatype change [\#2532](https://github.com/apache/arrow-rs/pull/2532) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor PrimitiveBuilder Constructors [\#2518](https://github.com/apache/arrow-rs/pull/2518) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactoring DecimalBuilder constructors [\#2517](https://github.com/apache/arrow-rs/pull/2517) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor FixedSizeBinaryBuilder Constructors [\#2516](https://github.com/apache/arrow-rs/pull/2516) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor BooleanBuilder Constructors [\#2515](https://github.com/apache/arrow-rs/pull/2515) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor UnionBuilder Constructors [\#2488](https://github.com/apache/arrow-rs/pull/2488) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
+- DictionaryBuilders can Create Invalid DictionaryArrays [\#2684](https://github.com/apache/arrow-rs/issues/2684) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)]

Review Comment:
   I agree -- I think this issue was marked with api-change by an earlier version of the script -- I have subsequently blacklisted (won't transfer) `api-change` labels to issues and will fix this one manually



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#issuecomment-1249564425

   I forgot to update one of the toml files: https://github.com/apache/arrow-rs/pull/2748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2734: Update version to `23.0.0` and update `CHANGELOG`, add `label_issue.py` script

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2734:
URL: https://github.com/apache/arrow-rs/pull/2734#discussion_r973144607


##########
CHANGELOG.md:
##########
@@ -19,119 +19,108 @@
 
 # Changelog
 
-## [22.0.0](https://github.com/apache/arrow-rs/tree/22.0.0) (2022-09-02)
+## [23.0.0](https://github.com/apache/arrow-rs/tree/23.0.0) (2022-09-16)
 
-[Full Changelog](https://github.com/apache/arrow-rs/compare/21.0.0...22.0.0)
+[Full Changelog](https://github.com/apache/arrow-rs/compare/22.0.0...23.0.0)
 
 **Breaking changes:**
 
-- Use `total_cmp` for floating value ordering and remove `nan_ordering` feature flag [\#2614](https://github.com/apache/arrow-rs/pull/2614) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([viirya](https://github.com/viirya))
-- Gate dyn comparison of dictionary arrays behind `dyn_cmp_dict` [\#2597](https://github.com/apache/arrow-rs/pull/2597) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([tustvold](https://github.com/tustvold))
-- Move JsonSerializable to json module \(\#2300\) [\#2595](https://github.com/apache/arrow-rs/pull/2595) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([tustvold](https://github.com/tustvold))
-- Decimal precision scale datatype change [\#2532](https://github.com/apache/arrow-rs/pull/2532) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor PrimitiveBuilder Constructors [\#2518](https://github.com/apache/arrow-rs/pull/2518) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactoring DecimalBuilder constructors [\#2517](https://github.com/apache/arrow-rs/pull/2517) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor FixedSizeBinaryBuilder Constructors [\#2516](https://github.com/apache/arrow-rs/pull/2516) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor BooleanBuilder Constructors [\#2515](https://github.com/apache/arrow-rs/pull/2515) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
-- Refactor UnionBuilder Constructors [\#2488](https://github.com/apache/arrow-rs/pull/2488) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] ([psvri](https://github.com/psvri))
+- DictionaryBuilders can Create Invalid DictionaryArrays [\#2684](https://github.com/apache/arrow-rs/issues/2684) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] [[arrow](https://github.com/apache/arrow-rs/labels/arrow)]

Review Comment:
   It seems a bit odd that we have both issues and PRs in here, perhaps we could exclude api-change from the auto-label, otherwise it obfuscates what the actual breaking change was?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org