You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andy Pang <pa...@huawei.com> on 2016/02/04 10:33:09 UTC

Review Request 43182: Support libprocess build run in aarch64 cpu.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43182/
-----------------------------------------------------------

Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Bugs: MESOS-4577
    https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description
-------

Support libprocess build run in aarch64 cpu.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 

Diff: https://reviews.apache.org/r/43182/diff/


Testing
-------

test run ok in AArch64.


Thanks,

Andy Pang

Re: Review Request 43182: Support libprocess build run in aarch64 cpu.

Posted by haosdent huang <ha...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43182/#review117789
-----------------------------------------------------------


Ship it!




Actually I not sure whether use a var to replace `2` or `1` would better or not. If it really could works on aarch64(I don't have a aarch64 machine), it looks good to me.

- haosdent huang


On Feb. 4, 2016, 9:33 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43182/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
> 
> Diff: https://reviews.apache.org/r/43182/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>