You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2013/03/11 22:35:12 UTC

[jira] [Commented] (KAFKA-800) inSyncReplica in Partition needs some tweaks

    [ https://issues.apache.org/jira/browse/KAFKA-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599343#comment-13599343 ] 

Jun Rao commented on KAFKA-800:
-------------------------------

Also, the leaderCount gauge in ReplicaManager needs to use the lock too.
                
> inSyncReplica in Partition needs some tweaks
> --------------------------------------------
>
>                 Key: KAFKA-800
>                 URL: https://issues.apache.org/jira/browse/KAFKA-800
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Sriram Subramanian
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>             Fix For: 0.8
>
>
> 1. isUnderReplicated method in Partition.scala needs to take the leaderIsrUpdateLock before reading the inSyncReplica structure. We suspect that this could cause the gauge to read stale values from the cache.
> 2. toString api should take the leaderIsrUpdateLock to prevent anything from blowing up when it iterates the data structures

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira