You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/10/19 13:38:42 UTC

[tomcat] branch main updated: Comment clean-up

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new bc030ec727 Comment clean-up
bc030ec727 is described below

commit bc030ec727aa1069bff9c98cbd935a11e69dd292
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Oct 19 14:38:35 2022 +0100

    Comment clean-up
---
 java/jakarta/servlet/jsp/JspContext.java     |  5 -----
 java/org/apache/jasper/compiler/JspUtil.java | 11 -----------
 2 files changed, 16 deletions(-)

diff --git a/java/jakarta/servlet/jsp/JspContext.java b/java/jakarta/servlet/jsp/JspContext.java
index 29168734e9..254d3ef2c9 100644
--- a/java/jakarta/servlet/jsp/JspContext.java
+++ b/java/jakarta/servlet/jsp/JspContext.java
@@ -59,11 +59,6 @@ import jakarta.el.ELContext;
  * The following methods provide <B>convenient access</B> to implicit objects:
  * <code>getOut()</code>
  *
- * <p>
- * The following methods provide <B>programmatic access</b> to the
- * Expression Language evaluator:
- * <code>getExpressionEvaluator()</code>, <code>getVariableResolver()</code>
- *
  * @since JSP 2.0
  */
 
diff --git a/java/org/apache/jasper/compiler/JspUtil.java b/java/org/apache/jasper/compiler/JspUtil.java
index 211ffe44b4..6a63a54a16 100644
--- a/java/org/apache/jasper/compiler/JspUtil.java
+++ b/java/org/apache/jasper/compiler/JspUtil.java
@@ -375,17 +375,6 @@ public class JspUtil {
         /*
          * Build up the base call to the interpreter.
          */
-        // XXX - We use a proprietary call to the interpreter for now
-        // as the current standard machinery is inefficient and requires
-        // lots of wrappers and adapters. This should all clear up once
-        // the EL interpreter moves out of JSTL and into its own project.
-        // In the future, this should be replaced by code that calls
-        // ExpressionEvaluator.parseExpression() and then cache the resulting
-        // expression objects. The interpreterCall would simply select
-        // one of the pre-cached expressions and evaluate it.
-        // Note that PageContextImpl implements VariableResolver and
-        // the generated Servlet/SimpleTag implements FunctionMapper, so
-        // that machinery is already in place (mroth).
         targetType = toJavaSourceType(targetType);
         StringBuilder call = new StringBuilder(
                 "("


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org