You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-cvs@xml.apache.org by mr...@apache.org on 2004/04/25 00:11:23 UTC
cvs commit: xml-commons/java/external/src/javax/xml/transform FactoryFinder.java
mrglavas 2004/04/24 15:11:23
Modified: java/external/src/javax/xml/parsers Tag: tck-jaxp-1_2_0
FactoryFinder.java
java/external/src/javax/xml/transform Tag: tck-jaxp-1_2_0
FactoryFinder.java
Log:
Performance Fix: When reaing the service provider name from a jar
a BufferedReader is used to read the first line from the
file. BufferedReader's default buffer size is 8K chars. Since
we're only reading one line (the name of a class) this is pretty
excessive. Reducing this size significantly to 80 chars.
Revision Changes Path
No revision
No revision
1.7.6.6 +7 -2 xml-commons/java/external/src/javax/xml/parsers/FactoryFinder.java
Index: FactoryFinder.java
===================================================================
RCS file: /home/cvs/xml-commons/java/external/src/javax/xml/parsers/FactoryFinder.java,v
retrieving revision 1.7.6.5
retrieving revision 1.7.6.6
diff -u -r1.7.6.5 -r1.7.6.6
--- FactoryFinder.java 12 Feb 2003 20:06:38 -0000 1.7.6.5
+++ FactoryFinder.java 24 Apr 2004 22:11:23 -0000 1.7.6.6
@@ -89,6 +89,11 @@
/** Cache the timestamp of the jaxp.properties file, if used. */
private static long lastModified = -1;
+
+ /**
+ * Default columns per line.
+ */
+ private static final int DEFAULT_LINE_LENGTH = 80;
// Define system property "jaxp.debug" to get output
static {
@@ -360,9 +365,9 @@
// jkesselm]
BufferedReader rd;
try {
- rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
+ rd = new BufferedReader(new InputStreamReader(is, "UTF-8"), DEFAULT_LINE_LENGTH);
} catch (java.io.UnsupportedEncodingException e) {
- rd = new BufferedReader(new InputStreamReader(is));
+ rd = new BufferedReader(new InputStreamReader(is), DEFAULT_LINE_LENGTH);
}
String factoryClassName = null;
No revision
No revision
1.7.6.6 +7 -2 xml-commons/java/external/src/javax/xml/transform/FactoryFinder.java
Index: FactoryFinder.java
===================================================================
RCS file: /home/cvs/xml-commons/java/external/src/javax/xml/transform/FactoryFinder.java,v
retrieving revision 1.7.6.5
retrieving revision 1.7.6.6
diff -u -r1.7.6.5 -r1.7.6.6
--- FactoryFinder.java 12 Feb 2003 20:06:38 -0000 1.7.6.5
+++ FactoryFinder.java 24 Apr 2004 22:11:23 -0000 1.7.6.6
@@ -89,6 +89,11 @@
/** Cache the timestamp of the jaxp.properties file, if used. */
private static long lastModified = -1;
+
+ /**
+ * Default columns per line.
+ */
+ private static final int DEFAULT_LINE_LENGTH = 80;
// Define system property "jaxp.debug" to get output
static {
@@ -360,9 +365,9 @@
// jkesselm]
BufferedReader rd;
try {
- rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
+ rd = new BufferedReader(new InputStreamReader(is, "UTF-8"), DEFAULT_LINE_LENGTH);
} catch (java.io.UnsupportedEncodingException e) {
- rd = new BufferedReader(new InputStreamReader(is));
+ rd = new BufferedReader(new InputStreamReader(is), DEFAULT_LINE_LENGTH);
}
String factoryClassName = null;