You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by Lukas Ott <ot...@gmail.com> on 2020/12/02 20:01:04 UTC

[DISCUSS] Apache PLC4X 1.4.0 RC1

This is the discussion thread for the corresponding VOTE thread.

   Please keep discussions in this thread to simplify the counting of votes.

   If you have to vote -1 please mention a brief description on why and
then take the details to this thread.

Re: [DISCUSS] Apache PLC4X build-tools 1.4.0 RC1

Posted by Ben Hutcheson <be...@gmail.com>.
Executable permissions aren't preserved on mvnw, might need to add it to
the README?

On Thu, Dec 3, 2020 at 3:35 AM Christofer Dutz <ch...@c-ware.de>
wrote:

> And the Readme does mention Java 8 …
>
> usage of the maven-wrapper keeps this the only requirement … in this case
> I should simply add a “w” to the maven command.
>
> Chris
>
>
> Von: Christofer Dutz <ch...@c-ware.de>
> Datum: Donnerstag, 3. Dezember 2020 um 09:34
> An: dev@plc4x.apache.org <de...@plc4x.apache.org>
> Betreff: AW: [DISCUSS] Apache PLC4X build-tools 1.4.0 RC1
> Hi All,
>
> So I did a quick check to what changed:
>
>
>   *   Added BooleanTypeReference.java
>   *   Moved the Default*TypeReferences from SPI into the types-base
>
> Not more …
>
> Chris
>
> Von: Lukas Ott <ot...@gmail.com>
> Datum: Donnerstag, 3. Dezember 2020 um 07:52
> An: dev@plc4x.apache.org <de...@plc4x.apache.org>
> Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> yes
>
> Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> ottobackwards@gmail.com>:
>
> >  you mean build tools?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 2, 2020 at 15:01:21
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject:  [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > This is the discussion thread for the corresponding VOTE thread.
> >
> > Please keep discussions in this thread to simplify the counting of votes.
> >
> > If you have to vote -1 please mention a brief description on why and
> > then take the details to this thread.
> >
>

AW: [DISCUSS] Apache PLC4X build-tools 1.4.0 RC1

Posted by Christofer Dutz <ch...@c-ware.de>.
And the Readme does mention Java 8 …

usage of the maven-wrapper keeps this the only requirement … in this case I should simply add a “w” to the maven command.

Chris


Von: Christofer Dutz <ch...@c-ware.de>
Datum: Donnerstag, 3. Dezember 2020 um 09:34
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: AW: [DISCUSS] Apache PLC4X build-tools 1.4.0 RC1
Hi All,

So I did a quick check to what changed:


  *   Added BooleanTypeReference.java
  *   Moved the Default*TypeReferences from SPI into the types-base

Not more …

Chris

Von: Lukas Ott <ot...@gmail.com>
Datum: Donnerstag, 3. Dezember 2020 um 07:52
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
yes

Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
ottobackwards@gmail.com>:

>  you mean build tools?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 2, 2020 at 15:01:21
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject:  [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> This is the discussion thread for the corresponding VOTE thread.
>
> Please keep discussions in this thread to simplify the counting of votes.
>
> If you have to vote -1 please mention a brief description on why and
> then take the details to this thread.
>

AW: [DISCUSS] Apache PLC4X build-tools 1.4.0 RC1

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi All,

So I did a quick check to what changed:


  *   Added BooleanTypeReference.java
  *   Moved the Default*TypeReferences from SPI into the types-base

Not more …

Chris

Von: Lukas Ott <ot...@gmail.com>
Datum: Donnerstag, 3. Dezember 2020 um 07:52
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
yes

Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
ottobackwards@gmail.com>:

>  you mean build tools?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 2, 2020 at 15:01:21
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject:  [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> This is the discussion thread for the corresponding VOTE thread.
>
> Please keep discussions in this thread to simplify the counting of votes.
>
> If you have to vote -1 please mention a brief description on why and
> then take the details to this thread.
>

AW: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Christofer Dutz <ch...@c-ware.de>.
And I even did the changes requested on develop already …

So I guess if we would get more +1s it’s up to you as RM, if you think these can be regarded minor enough.
2 other PMCs currently have standing +1s.

If you don’t mind the effort and would like to learn the rest of the RM work, feel free to go for a new RC.
I would not consider this a reason to do a RC2, but having one PMC seeing it as a valid reason would probably make me go for an RC2.

Chris



Von: Christofer Dutz <ch...@c-ware.de>
Datum: Donnerstag, 3. Dezember 2020 um 14:47
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: AW: [DISCUSS] Apache PLC4X 1.4.0 RC1
So far this was all.

Chris


Von: Lukas Ott <ot...@gmail.com>
Datum: Donnerstag, 3. Dezember 2020 um 14:44
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
To summarize - The main points for RC2 would be:
- Update the Release Notes
-> Minor Changes to the types
- Update ReadME
-> Java 8 or higher and "mvnw"

Am I missing something?



Am Do., 3. Dez. 2020 um 14:18 Uhr schrieb Christofer Dutz <
christofer.dutz@c-ware.de>:

> At first I was just worried to make things too complicated for Lukas as
> this is his first go at being a RM,
>
> But perhaps this makes the training experience even better … so if Lukas
> decides to do an RC2, I’ll be available via Zoom to be of assistance.
> (Still hot half a bottle of mulled wine … so I should be able to help for a
> RC2 … RC3 things start getting critical) ;-)
>
> Chris
>
> Von: Ben Hutcheson <hu...@apache.org>
> Datum: Donnerstag, 3. Dezember 2020 um 14:10
> An: dev@plc4x.apache.org <de...@plc4x.apache.org>
> Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> Otto,
>
> You are absolutely right, I retract my comment.
>
> Sorry about that.
>
> Ben
>
>
> On Thu, Dec 3, 2020 at 7:54 AM Otto Fowler <ot...@gmail.com>
> wrote:
>
> >  The release notes are not required for the project from an apache POV.
> > If we aren’t going to do them, then remove the file, and remove it from
> the
> > list of approval criteria.
> >
> > If we do have them in those things, then do them right. I don’t see what
> > the issue is with doing them correctly.
> >
> > Are we in some rush?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 3, 2020 at 01:52:11
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > yes
> >
> > Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> > ottobackwards@gmail.com>:
> >
> > > you mean build tools?
> > >
> > > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <
> dev@plc4x.apache.org
> > >
> > > Date: December 2, 2020 at 15:01:21
> > > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > > Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
> > >
> > > This is the discussion thread for the corresponding VOTE thread.
> > >
> > > Please keep discussions in this thread to simplify the counting of
> votes.
> > >
> > > If you have to vote -1 please mention a brief description on why and
> > > then take the details to this thread.
> > >
> >
>

AW: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Christofer Dutz <ch...@c-ware.de>.
So far this was all.

Chris


Von: Lukas Ott <ot...@gmail.com>
Datum: Donnerstag, 3. Dezember 2020 um 14:44
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
To summarize - The main points for RC2 would be:
- Update the Release Notes
-> Minor Changes to the types
- Update ReadME
-> Java 8 or higher and "mvnw"

Am I missing something?



Am Do., 3. Dez. 2020 um 14:18 Uhr schrieb Christofer Dutz <
christofer.dutz@c-ware.de>:

> At first I was just worried to make things too complicated for Lukas as
> this is his first go at being a RM,
>
> But perhaps this makes the training experience even better … so if Lukas
> decides to do an RC2, I’ll be available via Zoom to be of assistance.
> (Still hot half a bottle of mulled wine … so I should be able to help for a
> RC2 … RC3 things start getting critical) ;-)
>
> Chris
>
> Von: Ben Hutcheson <hu...@apache.org>
> Datum: Donnerstag, 3. Dezember 2020 um 14:10
> An: dev@plc4x.apache.org <de...@plc4x.apache.org>
> Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> Otto,
>
> You are absolutely right, I retract my comment.
>
> Sorry about that.
>
> Ben
>
>
> On Thu, Dec 3, 2020 at 7:54 AM Otto Fowler <ot...@gmail.com>
> wrote:
>
> >  The release notes are not required for the project from an apache POV.
> > If we aren’t going to do them, then remove the file, and remove it from
> the
> > list of approval criteria.
> >
> > If we do have them in those things, then do them right. I don’t see what
> > the issue is with doing them correctly.
> >
> > Are we in some rush?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 3, 2020 at 01:52:11
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > yes
> >
> > Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> > ottobackwards@gmail.com>:
> >
> > > you mean build tools?
> > >
> > > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <
> dev@plc4x.apache.org
> > >
> > > Date: December 2, 2020 at 15:01:21
> > > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > > Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
> > >
> > > This is the discussion thread for the corresponding VOTE thread.
> > >
> > > Please keep discussions in this thread to simplify the counting of
> votes.
> > >
> > > If you have to vote -1 please mention a brief description on why and
> > > then take the details to this thread.
> > >
> >
>

Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Lukas Ott <ot...@gmail.com>.
To summarize - The main points for RC2 would be:
- Update the Release Notes
-> Minor Changes to the types
- Update ReadME
-> Java 8 or higher and "mvnw"

Am I missing something?



Am Do., 3. Dez. 2020 um 14:18 Uhr schrieb Christofer Dutz <
christofer.dutz@c-ware.de>:

> At first I was just worried to make things too complicated for Lukas as
> this is his first go at being a RM,
>
> But perhaps this makes the training experience even better … so if Lukas
> decides to do an RC2, I’ll be available via Zoom to be of assistance.
> (Still hot half a bottle of mulled wine … so I should be able to help for a
> RC2 … RC3 things start getting critical) ;-)
>
> Chris
>
> Von: Ben Hutcheson <hu...@apache.org>
> Datum: Donnerstag, 3. Dezember 2020 um 14:10
> An: dev@plc4x.apache.org <de...@plc4x.apache.org>
> Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> Otto,
>
> You are absolutely right, I retract my comment.
>
> Sorry about that.
>
> Ben
>
>
> On Thu, Dec 3, 2020 at 7:54 AM Otto Fowler <ot...@gmail.com>
> wrote:
>
> >  The release notes are not required for the project from an apache POV.
> > If we aren’t going to do them, then remove the file, and remove it from
> the
> > list of approval criteria.
> >
> > If we do have them in those things, then do them right. I don’t see what
> > the issue is with doing them correctly.
> >
> > Are we in some rush?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 3, 2020 at 01:52:11
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > yes
> >
> > Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> > ottobackwards@gmail.com>:
> >
> > > you mean build tools?
> > >
> > > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <
> dev@plc4x.apache.org
> > >
> > > Date: December 2, 2020 at 15:01:21
> > > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > > Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
> > >
> > > This is the discussion thread for the corresponding VOTE thread.
> > >
> > > Please keep discussions in this thread to simplify the counting of
> votes.
> > >
> > > If you have to vote -1 please mention a brief description on why and
> > > then take the details to this thread.
> > >
> >
>

AW: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Christofer Dutz <ch...@c-ware.de>.
At first I was just worried to make things too complicated for Lukas as this is his first go at being a RM,

But perhaps this makes the training experience even better … so if Lukas decides to do an RC2, I’ll be available via Zoom to be of assistance. (Still hot half a bottle of mulled wine … so I should be able to help for a RC2 … RC3 things start getting critical) ;-)

Chris

Von: Ben Hutcheson <hu...@apache.org>
Datum: Donnerstag, 3. Dezember 2020 um 14:10
An: dev@plc4x.apache.org <de...@plc4x.apache.org>
Betreff: Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
Otto,

You are absolutely right, I retract my comment.

Sorry about that.

Ben


On Thu, Dec 3, 2020 at 7:54 AM Otto Fowler <ot...@gmail.com> wrote:

>  The release notes are not required for the project from an apache POV.
> If we aren’t going to do them, then remove the file, and remove it from the
> list of approval criteria.
>
> If we do have them in those things, then do them right. I don’t see what
> the issue is with doing them correctly.
>
> Are we in some rush?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 3, 2020 at 01:52:11
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> yes
>
> Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> ottobackwards@gmail.com>:
>
> > you mean build tools?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 2, 2020 at 15:01:21
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > This is the discussion thread for the corresponding VOTE thread.
> >
> > Please keep discussions in this thread to simplify the counting of votes.
> >
> > If you have to vote -1 please mention a brief description on why and
> > then take the details to this thread.
> >
>

Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Ben Hutcheson <hu...@apache.org>.
Otto,

You are absolutely right, I retract my comment.

Sorry about that.

Ben


On Thu, Dec 3, 2020 at 7:54 AM Otto Fowler <ot...@gmail.com> wrote:

>  The release notes are not required for the project from an apache POV.
> If we aren’t going to do them, then remove the file, and remove it from the
> list of approval criteria.
>
> If we do have them in those things, then do them right. I don’t see what
> the issue is with doing them correctly.
>
> Are we in some rush?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 3, 2020 at 01:52:11
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> yes
>
> Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
> ottobackwards@gmail.com>:
>
> > you mean build tools?
> >
> > From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> > Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <dev@plc4x.apache.org
> >
> > Date: December 2, 2020 at 15:01:21
> > To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> > Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
> >
> > This is the discussion thread for the corresponding VOTE thread.
> >
> > Please keep discussions in this thread to simplify the counting of votes.
> >
> > If you have to vote -1 please mention a brief description on why and
> > then take the details to this thread.
> >
>

Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Otto Fowler <ot...@gmail.com>.
 The release notes are not required for the project from an apache POV.
If we aren’t going to do them, then remove the file, and remove it from the
list of approval criteria.

If we do have them in those things, then do them right. I don’t see what
the issue is with doing them correctly.

Are we in some rush?

From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
Date: December 3, 2020 at 01:52:11
To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
Subject:  Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

yes

Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
ottobackwards@gmail.com>:

> you mean build tools?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 2, 2020 at 15:01:21
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject: [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> This is the discussion thread for the corresponding VOTE thread.
>
> Please keep discussions in this thread to simplify the counting of votes.
>
> If you have to vote -1 please mention a brief description on why and
> then take the details to this thread.
>

Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Lukas Ott <ot...@gmail.com>.
yes

Am Mi., 2. Dez. 2020 um 22:43 Uhr schrieb Otto Fowler <
ottobackwards@gmail.com>:

>  you mean build tools?
>
> From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
> Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Date: December 2, 2020 at 15:01:21
> To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
> Subject:  [DISCUSS] Apache PLC4X 1.4.0 RC1
>
> This is the discussion thread for the corresponding VOTE thread.
>
> Please keep discussions in this thread to simplify the counting of votes.
>
> If you have to vote -1 please mention a brief description on why and
> then take the details to this thread.
>

Re: [DISCUSS] Apache PLC4X 1.4.0 RC1

Posted by Otto Fowler <ot...@gmail.com>.
 you mean build tools?

From: Lukas Ott <ot...@gmail.com> <ot...@gmail.com>
Reply: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
Date: December 2, 2020 at 15:01:21
To: dev@plc4x.apache.org <de...@plc4x.apache.org> <de...@plc4x.apache.org>
Subject:  [DISCUSS] Apache PLC4X 1.4.0 RC1

This is the discussion thread for the corresponding VOTE thread.

Please keep discussions in this thread to simplify the counting of votes.

If you have to vote -1 please mention a brief description on why and
then take the details to this thread.