You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/19 20:26:39 UTC
[jira] [Commented] (TINKERPOP-997) FeatureRequirementSet.SIMPLE
should not require multi-property
[ https://issues.apache.org/jira/browse/TINKERPOP-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107252#comment-15107252 ]
ASF GitHub Bot commented on TINKERPOP-997:
------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/205
TINKERPOP-997 - Feature and FeatureRequirement adjustments
As they were very closely related, this PR covers:
https://issues.apache.org/jira/browse/TINKERPOP-997
https://issues.apache.org/jira/browse/TINKERPOP-998
it deprecates a `Feature` that was basically a duplicate of another. It also opens up a good number of test cases to graphs that don't support meta-properties as there was a mis-definition of the `SIMPLE` requirement set.
Tested with `mvn clean install -DincludeNeo4j` and all was good. Also temporarily modified the TinkerGraph feature for meta-property support and manually noted that the right test cases opened up and closed down based on this change. Would be nice to get some verification from other graphs that this change is all good.
@jdellithorpe please take a look at this change when you get a moment, as you were the one who noted the problem in the first place. Looks like we get about 90 tests opened up as a result of this.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-997
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit cc6f10dbee050136729a407dd50b2c123729ebdb
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-01-19T17:53:56Z
TINKERPOP-998 Deprecated the VertexPropertyFeatures.FEATURE_ADD_PROPERTY.
Replaced by the already existing (duplicate) VertexFeatures.FEATURE_META_PROPERTIES.
commit 74cd88cede4439a93ec764fce623d4a499052336
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-01-19T18:58:28Z
TINKERPOP-997 FeatureRequirementSet.SIMPLE uses VertexFeatures.FEATURE_ADD_PROPERTY
This opens up a large number of tests in the test suite (about 90 or so) - providers may see some breakage as a result.
----
> FeatureRequirementSet.SIMPLE should not require multi-property
> --------------------------------------------------------------
>
> Key: TINKERPOP-997
> URL: https://issues.apache.org/jira/browse/TINKERPOP-997
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.1.1-incubating
>
>
> The intention was not to include multi-property - it was supposed to just allow properties on vertices which is a pretty low bar. Includes the "breaking" label because it will open up tests for some graphs and could cause them to have failing tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)