You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yuxiqian (via GitHub)" <gi...@apache.org> on 2024/08/27 06:47:18 UTC
[PR] [hotfix] Run schema coordinator logic asynchronously to avoid blocking the main thread [flink-cdc]
yuxiqian opened a new pull request, #3577:
URL: https://github.com/apache/flink-cdc/pull/3577
This tweaks `SchemaRegistry` coordinator to let it handle requests / trigger checkpoints in background threads to avoid blocking the main thread.
This also adds E2e test case running on various parallelisms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Run schema coordinator logic asynchronously to avoid blocking the main thread [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3577:
URL: https://github.com/apache/flink-cdc/pull/3577#discussion_r1732395696
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistry.java:
##########
@@ -113,18 +119,27 @@ public class SchemaRegistry implements OperatorCoordinator, CoordinationRequestH
public SchemaRegistry(
String operatorName,
OperatorCoordinator.Context context,
+ ExecutorService executorService,
MetadataApplier metadataApplier,
List<RouteRule> routes) {
- this(operatorName, context, metadataApplier, routes, SchemaChangeBehavior.EVOLVE);
+ this(
+ operatorName,
+ context,
+ executorService,
+ metadataApplier,
+ routes,
+ SchemaChangeBehavior.EVOLVE);
Review Comment:
LENIENT ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][cdc-runtime] Run schema coordinator logic asynchronously to avoid blocking the main thread [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #3577:
URL: https://github.com/apache/flink-cdc/pull/3577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Run schema coordinator logic asynchronously to avoid blocking the main thread [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #3577:
URL: https://github.com/apache/flink-cdc/pull/3577#issuecomment-2311762537
@loserwang1024 Would you like to review this PR when you have time ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org