You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by asm0dey <gi...@git.apache.org> on 2016/09/24 19:49:51 UTC
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
GitHub user asm0dey opened a pull request:
https://github.com/apache/thrift/pull/1094
Fixes THRIFT-3855
Replaced complex CompareAndSwapInt64 with syncOnce.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asm0dey/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1094
----
commit 762c2573e2275307b26ac78271b66d37065ed5f9
Author: Paul <pa...@gmail.com>
Date: 2016-09-24T19:47:58Z
Fixes THRIFT-3855
Replaced complex CompareAndSwapInt64 with syncOnce.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80392522
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
I would doubt that. If that is true that would probably qualify for a bug report. I would not expect a formatting tool to arbitrarily delete valid code lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80390983
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
I can't see the connection. Please explain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by asm0dey <gi...@git.apache.org>.
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80391820
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
@Jens-G --^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by asm0dey <gi...@git.apache.org>.
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80391813
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
It's removed by gofmt. I thought that gofmt knows better tan me, so I didn't revert that change. should I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by asm0dey <gi...@git.apache.org>.
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80392646
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
@Jens-G Reverted back that change. Thank you for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by asm0dey <gi...@git.apache.org>.
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80414179
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
And again I dunno why one of builds has failed, but it looks like it's nothing to do with Fo code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1094: Fixes THRIFT-3855
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80390991
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client TTransport) error {
log.Printf("error processing request: %s", err)
return err
}
- if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
- continue
- }
--- End diff --
How is that related? Please explain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---