You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "lavakush07 (via GitHub)" <gi...@apache.org> on 2023/02/02 17:55:13 UTC
[GitHub] [incubator-devlake-website] lavakush07 opened a new pull request, #418: Updated the [Install via docker compose command]
lavakush07 opened a new pull request, #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [✅ ] I have `npm run build` and `npm run serve` locally before submitting this PR
- [✅ ] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation
# Summary
<!--
Thanks for submitting a PR! We appreciate you spending the time to work on these changes. Please fill out as many sections below as possible.
-->
### Does this close any open issues?
https://github.com/apache/incubator-devlake/issues/4290
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] abeizn merged pull request #418: Updated the [Install via docker compose command]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] Startrekzky commented on a diff in pull request #418: Updated the [Install via docker compose command]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on code in PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#discussion_r1098120317
##########
docs/GettingStarted/DockerComposeSetup.md:
##########
@@ -17,7 +17,7 @@ sidebar_position: 1
1. Download `docker-compose.yml` and `env.example` from [latest release page](https://github.com/apache/incubator-devlake/releases/latest) into a folder.
2. Rename `env.example` to `.env`. For Mac/Linux users, please run `mv env.example .env` in the terminal. This file contains the environment variables that the Devlake server will use. Additional ones can be found in the compose file(s).
-3. Run `docker-compose up -d` to launch DevLake.
+3. If [Docker v2.13.0+](https://docs.docker.com/get-docker) Run `docker compose up -d` to launch DevLake or else Run `docker-compose up -d`.
Review Comment:
The wording needs polishing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] abeizn commented on a diff in pull request #418: Updated the [Install via docker compose command]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#discussion_r1118249189
##########
docs/GettingStarted/DockerComposeSetup.md:
##########
@@ -17,7 +17,7 @@ sidebar_position: 1
1. Download `docker-compose.yml` and `env.example` from [latest release page](https://github.com/apache/incubator-devlake/releases/latest) into a folder.
2. Rename `env.example` to `.env`. For Mac/Linux users, please run `mv env.example .env` in the terminal. This file contains the environment variables that the Devlake server will use. Additional ones can be found in the compose file(s).
-3. Run `docker-compose up -d` to launch DevLake.
+3. If [Docker v2.13.0+](https://docs.docker.com/get-docker) Run `docker compose up -d` to launch DevLake or else Run `docker-compose up -d`.
Review Comment:
> The wording needs polishing.
merge first, I will update later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] lavakush07 commented on pull request #418: Updated the [Install via docker compose command]
Posted by "lavakush07 (via GitHub)" <gi...@apache.org>.
lavakush07 commented on PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#issuecomment-1419536626
> > Can I please get more clarity on this as it was mentioned in the website : 
>
> Or you should add a sentence, if the version of docker desktop installed by the user is too low to use `docker compose up -d`, please use `docker-compose up -d`
Thank you @abeizn , Updated the PR with the required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] abeizn commented on pull request #418: Updated the [Install via docker compose command]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#issuecomment-1418421488
> Can I please get more clarity on this as it was mentioned in the website : 
Or you should add a sentence, if the version of docker desktop installed by the user is too low to use `docker compose up -d`, please use `docker-compose up -d`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] abeizn commented on pull request #418: Updated the [Install via docker compose command]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#issuecomment-1414672166
@lavakush07 Thanks for you pr, Docker Compose was introduced in this version (Docker Inc., v2.13.0), so i think docker-compose is right. Or in the doc, when the user use docker v2.13.0, them can use docker-compose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] lavakush07 commented on pull request #418: Updated the [Install via docker compose command]
Posted by "lavakush07 (via GitHub)" <gi...@apache.org>.
lavakush07 commented on PR #418:
URL: https://github.com/apache/incubator-devlake-website/pull/418#issuecomment-1416668232
Can I please get more clarity on this as it was mentioned in the website :
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org