[GitHub] [incubator-superset] rusackas commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library

[GitBox <gi...@apache.org>]

rusackas commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-665446027


   FWIW, I haven't found a need to use the react wrapper for eCharts thus far. A `useEffect` hook with a `ref` seems to work just great for Superset's purposes.
   
   It's worth re-mentioning, this SIP is to use ECharts as the _main_ charting library, particularly for the core plugins, but not necessarily the _only_ one on the table for use in Superset. As mentioned in the SIP, this decisoun should not preclude people from creating plugins using alternate libraries. In fact, I'm hyped up about it! We just need to figure out how/where to support those plugins, which is another discussion taking shape on Slack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org