You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/05/06 14:47:17 UTC
Review Request 70598: Added blogpost for 1.8.0 release.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Added blogpost for 1.8.0 release.
Diffs
-----
site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
Diff: https://reviews.apache.org/r/70598/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70598: Added blogpost for 1.8.0 release.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215098
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On May 7, 2019, 6:23 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
>
> (Updated May 7, 2019, 6:23 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blogpost for 1.8.0 release.
>
>
> Diffs
> -----
>
> site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70598/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70598: Added blogpost for 1.8.0 release.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/
-----------------------------------------------------------
(Updated May 7, 2019, 6:23 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Added blogpost for 1.8.0 release.
Diffs (updated)
-----
site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
Diff: https://reviews.apache.org/r/70598/diff/2/
Changes: https://reviews.apache.org/r/70598/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70598: Added blogpost for 1.8.0 release.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215062
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On May 6, 2019, 2:47 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
>
> (Updated May 6, 2019, 2:47 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blogpost for 1.8.0 release.
>
>
> Diffs
> -----
>
> site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70598/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70598: Added blogpost for 1.8.0 release.
Posted by Benno Evers <be...@mesosphere.com>.
> On May 6, 2019, 5:45 p.m., Benjamin Mahler wrote:
> > site/source/blog/2019-05-02-mesos-1-8-0-released.md
> > Lines 16-49 (patched)
> > <https://reviews.apache.org/r/70598/diff/1/?file=2143175#file2143175line16>
> >
> > These snippets should probably be in triple backtick sections to ensure they are monospaced and lined up when rendered?
Having 4 leading spaces is actually an alternative syntax for monospace blocks. (at least for my local website preview)
> On May 6, 2019, 5:45 p.m., Benjamin Mahler wrote:
> > site/source/blog/2019-05-02-mesos-1-8-0-released.md
> > Lines 38-49 (patched)
> > <https://reviews.apache.org/r/70598/diff/1/?file=2143175#file2143175line38>
> >
> > is this lines of code? commits touching the files? something else?
> >
> > the subfolder stuff seems a bit bizarre here, for example, is the number for src/ `src - src subfolders shown above`?
> >
> > Perhaps a hierarchically displayed version will be less prone to confusion?
> >
> > ```
> > 30.2% src/
> > 11.0% src/master
> > 7.8% src/cli
> > 4.0% support/
> > 3.7% support/python3/
> >
> > ```
> >
> > But then 11% here isn't clear if it's 11% of src's 30% or 11% of the overall changes.
> >
> > I don't have any good suggestions, but I think the summary stats are interesting. Curious how other projects display them..
Good idea, the original numbers were non-cumulative, but I agree that hierarchical, cumulative numbers are easier to understand.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215065
-----------------------------------------------------------
On May 7, 2019, 6:23 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
>
> (Updated May 7, 2019, 6:23 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blogpost for 1.8.0 release.
>
>
> Diffs
> -----
>
> site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70598/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70598: Added blogpost for 1.8.0 release.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215065
-----------------------------------------------------------
Fix it, then Ship it!
Thanks Benno!
Showing stats seems interesting, maybe just things like JIRA ticket count, # of commits, # lines added / deleted, as opposed to which files and folders?
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 13-14 (patched)
<https://reviews.apache.org/r/70598/#comment301449>
number of commits as well?
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 14 (patched)
<https://reviews.apache.org/r/70598/#comment301448>
the period here will lead people to interpret it as 60 rather than 60000 (in american english at least..), you could use "k" or nothing?
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 16-49 (patched)
<https://reviews.apache.org/r/70598/#comment301447>
These snippets should probably be in triple backtick sections to ensure they are monospaced and lined up when rendered?
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 38-49 (patched)
<https://reviews.apache.org/r/70598/#comment301450>
is this lines of code? commits touching the files? something else?
the subfolder stuff seems a bit bizarre here, for example, is the number for src/ `src - src subfolders shown above`?
Perhaps a hierarchically displayed version will be less prone to confusion?
```
30.2% src/
11.0% src/master
7.8% src/cli
4.0% support/
3.7% support/python3/
```
But then 11% here isn't clear if it's 11% of src's 30% or 11% of the overall changes.
I don't have any good suggestions, but I think the summary stats are interesting. Curious how other projects display them..
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 54 (patched)
<https://reviews.apache.org/r/70598/#comment301452>
newline?
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 59 (patched)
<https://reviews.apache.org/r/70598/#comment301451>
s/F/f/ or should probably just say scheduler to stay consistent with the rest of this section and to be clear that it's the scheduler part of the framework
site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 141 (patched)
<https://reviews.apache.org/r/70598/#comment301453>
extra newline here?
- Benjamin Mahler
On May 6, 2019, 2:47 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
>
> (Updated May 6, 2019, 2:47 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blogpost for 1.8.0 release.
>
>
> Diffs
> -----
>
> site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70598/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>