You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2025/05/19 10:16:19 UTC

[Bug 69694] New: Manager Deploy does not check return value of war copy

https://bz.apache.org/bugzilla/show_bug.cgi?id=69694

            Bug ID: 69694
           Summary: Manager Deploy does not check return value of war copy
           Product: Tomcat 9
           Version: 9.0.102
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Manager
          Assignee: dev@tomcat.apache.org
          Reporter: rgransberger@mekos.de
  Target Milestone: -----

ManagerServlet.deploy does not check the return value of ExpandWar.copy which
returns false on Exception.

The return value from manager\text\deploy indicates that the deploy succeeded
which is not the case.

I checked the code in the Tomcat 9 branch and it's not fixed yet.

Here's the stack trace which is only logged.

14-May-2025 12:15:09.053 INFO [ajp-nio-127.0.0.1-8009-exec-8]
org.apache.catalina.core.ApplicationContext.log Manager: Uploading WAR file to
D:\Tomcat\work\manager\20250514_1445\ROOT.war
14-May-2025 12:15:13.375 SEVERE [ajp-nio-127.0.0.1-8009-exec-8]
org.apache.catalina.startup.ExpandWar.copy Error copying
[D:\Tomcat\work\manager\20250514_1445\ROOT.war] to [D:\Tomcat\webapps\ROOT.war]
        java.io.FileNotFoundException: D:\Tomcat\webapps\ROOT.war (Access
denied)
                at java.base/java.io.FileOutputStream.open0(Native Method)
                at
java.base/java.io.FileOutputStream.open(FileOutputStream.java:289)
                at
java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:230)
                at
java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:179)
                at
org.apache.catalina.startup.ExpandWar.copy(ExpandWar.java:256)
                at
org.apache.catalina.manager.ManagerServlet.deploy(ManagerServlet.java:763)
                at
org.apache.catalina.manager.ManagerServlet.doPut(ManagerServlet.java:398)
                at javax.servlet.http.HttpServlet.service(HttpServlet.java:558)
                at javax.servlet.http.HttpServlet.service(HttpServlet.java:623)
                at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:199)
                at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
                at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
                at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
                at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
                at
org.apache.catalina.filters.HttpHeaderSecurityFilter.doFilter(HttpHeaderSecurityFilter.java:129)
                at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168)
                at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144)
                at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168)
                at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
                at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:597)
                at
org.apache.catalina.valves.RequestFilterValve.process(RequestFilterValve.java:355)
                at
org.apache.catalina.valves.RemoteAddrValve.invoke(RemoteAddrValve.java:54)
                at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130)
                at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
                at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:660)
                at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
                at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346)
                at
org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:424)
                at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
                at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:937)
                at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1793)
                at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
                at
org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190)
                at
org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
                at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
                at java.base/java.lang.Thread.run(Thread.java:1583)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 69694] Manager Deploy does not check return value of war copy

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69694

Remy Maucherat <re...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 OS|                            |All
             Status|NEW                         |RESOLVED

--- Comment #1 from Remy Maucherat <re...@apache.org> ---
Good idea. The fix will be in 11.0.8, 10.1.42 and 9.0.106.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org