[GitHub] azai91 commented on a change in pull request #11308: [MXNET-551] Test CreateMKLDNNMem/CommitOutput

[GitBox <gi...@apache.org>]

azai91 commented on a change in pull request #11308: [MXNET-551] Test CreateMKLDNNMem/CommitOutput
URL: https://github.com/apache/incubator-mxnet/pull/11308#discussion_r197263742
 
 

 ##########
 File path: tests/cpp/operator/mkldnn.cc
 ##########
 @@ -834,4 +855,89 @@ TEST(MKLDNN_BASE, MKLDNNSum) {
   }
 }
 
+TEST(MKLDNN_BASE, CreateMKLDNNMem) {
 
 Review comment:
   test on sum doesn't use createmkldnnmem/commitoutput. I use the sum helper for this test cause copy doesn't support writeinplace (or doesnt really make sense). there is a separate mkldnnsum test that doesn't use createmkldnnmem/commitout that solely tests the purpose of the mkldnnsum. for future test on helper functions, they will follow a similar format to mkldnnsum without createmkldnn/commitout so it will be easier to see if the problem is with the helper or with createmkldnn/commitoutput.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services