[jira] [Comment Edited] (OAK-5160) change Nonnull to Nullable in FilteringAwareObserver.contentChanged

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693455#comment-15693455 ] 

Stefan Egli edited comment on OAK-5160 at 11/24/16 2:48 PM:
------------------------------------------------------------

good point. I think {{DiffObserver}} and {{FilteringAwareObserver}} are different though: the former receives all changes while the latter is aware that there might be gaps.
However, we could also change the -{{FilteringObserver}}- {{FilteringDispatcher}} to not send the very first change (same as DiffObserver does) - that way it would be indeed {{@Nonnull}}...


was (Author: egli):
good point. I think {{DiffObserver}} and {{FilteringAwareObserver}} are different though: the former receives all changes while the latter is aware that there might be gaps.
However, we could also change the {{FilteringObserver}} to not send the very first change (same as DiffObserver does) - that way it would be indeed {{@Nonnull}}...

> change Nonnull to Nullable in FilteringAwareObserver.contentChanged
> -------------------------------------------------------------------
>
>                 Key: OAK-5160
>                 URL: https://issues.apache.org/jira/browse/OAK-5160
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.5.14
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.6, 1.5.15
>
>
> FilteringAwareObserver (and thus ChangeProcessor)'s {{contentChanged}} has {{@Nonnull}} for the {{before}} parameter. But for the very first contentChanged (at initialization time) this can actually be null. So we should change that to {{@Nullable}} there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)