You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 08:05:27 UTC

[GitHub] [flink] chucheng92 opened a new pull request, #19568: [FLINK-27381][connector/common] Use Arrays.hashcode for HybridSourceSplit wrappedSplitBytes

chucheng92 opened a new pull request, #19568:
URL: https://github.com/apache/flink/pull/19568

   ## What is the purpose of the change
   
   HybridSourceSplit's wrappedSplit should use Arrays.hashCode because wrappedSplit has been changed from `SourceSplit` object to serialized wrappedBytes array.
   
   ## Brief change log
   
   Correct HybridSourceSplit hashCode method.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `HybridSourceSplitSerializerTest`, `HybridSourceSplitEnumeratorTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature?  no
   - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19568: [FLINK-27381][connector/common] Use Arrays.hashcode for HybridSourceSplit wrappedSplitBytes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19568:
URL: https://github.com/apache/flink/pull/19568#issuecomment-1108225450

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f3763a986dda131de7ef7b6c3579d2293956b27",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3f3763a986dda131de7ef7b6c3579d2293956b27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f3763a986dda131de7ef7b6c3579d2293956b27 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tweise merged pull request #19568: [FLINK-27381][connector/common] Use Arrays.hashcode for HybridSourceSplit wrappedSplitBytes

Posted by GitBox <gi...@apache.org>.
tweise merged PR #19568:
URL: https://github.com/apache/flink/pull/19568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org