[GitHub] [incubator-kvrocks] mapleFU commented on a diff in pull request #1419: Support specify release candidate number

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #1419:
URL: https://github.com/apache/incubator-kvrocks/pull/1419#discussion_r1185663225


##########
x.py:
##########
@@ -216,16 +216,18 @@ def write_version(release_version: str) -> str:
     return version
 
 
-def package_source(release_version: str) -> None:
+def package_source(release_version: str, release_candidate_number: int) -> None:

Review Comment:
   Should it be an optional ( https://docs.python.org/3/library/typing.html#typing.Optional ) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org