You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/04/06 00:06:08 UTC
Re: Review Request 57896: Renamed config.py to settings.py in the new
CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57896/#review171179
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On March 27, 2017, 11:56 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57896/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 11:56 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7269
> https://issues.apache.org/jira/browse/MESOS-7269
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change made due to the upcoming introduction of a `config` plugin.
>
>
> Diffs
> -----
>
> src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37
> src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d
>
>
> Diff: https://reviews.apache.org/r/57896/diff/3/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>