You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2007/06/15 01:07:25 UTC
[jira] Created: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
----------------------------------------------------------------------------------------
Key: DERBY-2824
URL: https://issues.apache.org/jira/browse/DERBY-2824
Project: Derby
Issue Type: Improvement
Components: JDBC
Affects Versions: 10.3.0.0
Reporter: Kristian Waagan
Assignee: Kristian Waagan
Priority: Minor
Fix For: 10.3.0.0
I plan to do the following changes to UTF8Reader:
* Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
* Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
* Remove trailing spaces, and add a few newlines here and there.
* Replace tabs in the file with spaces.
Now, the last point can be discussed, but here are my arguments for doing it:
* The file now has a mix of tabs and spaces (but still more tabs).
* Spaces are the preferred/required method of indentation.
* I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
* I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
* Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
Please raise your concern as soon as possible if you want to veto these changes.
I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Attachment: derby-2824-4a-javadoc.diff
'derby-2824-4a-javadoc.diff' adds new JavaDoc and changes some of the existing.
In addition, it removes an 'throws IOException' from one of the constructors and makes the variable 'buffer' final.
suites.All ran without failures (9535 tests, Java SE 6).
This is my last patch for this issue.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4, 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff, derby-2824-4a-javadoc.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-2824.
----------------------------------
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4, 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff, derby-2824-4a-javadoc.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Attachment: derby-2824-1a-tabs_to_spaces.diff
'derby-2824-1a-tabs_to_spaces.diff' replaces all tabs in UTF8Reader with 4 spaces.
No other changes made.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Attachment: derby-2824-3b-improved_error_reporting.diff
'derby-2824-3b-improved_error_reporting.diff' fixes a few language inconsistencies and one use of a wrong variable.
Ran derbyall/suites.All without failures.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (DERBY-2824) Improve error reporting,
fix whitespace/formatting issues and replace tabs in UTF8Reader
Posted by Kristian Waagan <Kr...@Sun.COM>.
Kathey Marsden wrote:
> Kristian Waagan (JIRA) wrote:
>>
>>> Improve error reporting, fix whitespace/formatting issues and replace
>>> tabs in UTF8Reader
>>>
> I think ideally it is good to keep whitespace/formatting diffs as a
> separate checkin. It makes it clearer which are code changes and which
> are not. Is it possible to have two checkins, one for the
> format/whitespace changes and another for the actual code changes?
Hello Kathey,
Sorry, but I'm a bit behind on the mail and didn't notice this one
before today. A swifter way to reach me would be to comment on the issue
itself through Jira.
I do normally pay attention to all mail, but sometimes the volume of
messages gets too high so I miss the important ones...
I separated the various fixes from the start, and the issue consists of
the following patches:
derby-2824-1a-tabs_to_spaces.diff
derby-2824-2a-whitespace_changes.diff
derby-2824-3b-improved_error_reporting.diff
derby-2824-4a-javadoc.diff
There will be no further work on the issue, and I have closed it.
regards,
--
Kristian
>
>
> Kathey
>
>
Re: [jira] Updated: (DERBY-2824) Improve error reporting, fix whitespace/formatting
issues and replace tabs in UTF8Reader
Posted by Kathey Marsden <km...@sbcglobal.net>.
Kristian Waagan (JIRA) wrote:
>
>> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
>>
I think ideally it is good to keep whitespace/formatting diffs as a
separate checkin. It makes it clearer which are code changes and which
are not. Is it possible to have two checkins, one for the
format/whitespace changes and another for the actual code changes?
Kathey
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Derby Info: [Patch Available]
Affects Version/s: 10.4.0.0
Fix Version/s: 10.4.0.0
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4, 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff, derby-2824-4a-javadoc.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505211 ]
Kristian Waagan commented on DERBY-2824:
----------------------------------------
Committed 'derby-2824-1a-tabs_to_spaces.diff' to trunk with revision 547653.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Derby Info: [Patch Available]
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Derby Info: (was: [Patch Available])
Committed 'derby-2824-3b-improved_error_reporting.diff' to trunk with revision 568086.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-2824.
------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Committed 'derby-2824-4a-javadoc.diff' to trunk with revision 581934.
This patch is the last patch planned, and I will close the issue soon.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.1.4, 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff, derby-2824-3b-improved_error_reporting.diff, derby-2824-4a-javadoc.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-2824:
--------------------------------------
Fix Version/s: (was: 10.3.0.0)
unsetting fix version. If this gets finished before July 5, fix version can be set then to appropriate version number.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Attachment: derby-2824-2a-whitespace_changes.diff
Committed 'derby-2824-2a-whitespace_changes.diff' to trunk with revision 547694.
Whitespace changes only.
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2824) Improve error reporting, fix
whitespace/formatting issues and replace tabs in UTF8Reader
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824:
-----------------------------------
Attachment: derby-2824-3a-improved_error_reporting.diff
'derby-2824-3a-improved_error_reporting.diff' adds message text to the IOException and UTFDataFormat exception thrown by the reader.
Please review.
I also plan to revise/add JavaDoc, but I won't do anything more on this issue before after the branch has been cut (unless that is postponed).
> Improve error reporting, fix whitespace/formatting issues and replace tabs in UTF8Reader
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2824
> URL: https://issues.apache.org/jira/browse/DERBY-2824
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: derby-2824-1a-tabs_to_spaces.diff, derby-2824-2a-whitespace_changes.diff, derby-2824-3a-improved_error_reporting.diff
>
>
> I plan to do the following changes to UTF8Reader:
> * Improve the error reporting when hitting a UTF8 decoding error (currently an UTFDataFormatException with no message). This might also lead to deleting one helper method for generating an exception (the one with no message).
> * Improve error reporting for trying to use the reader after it has been closed (currently an IOException with no message).
> * Remove trailing spaces, and add a few newlines here and there.
> * Replace tabs in the file with spaces.
> Now, the last point can be discussed, but here are my arguments for doing it:
> * The file now has a mix of tabs and spaces (but still more tabs).
> * Spaces are the preferred/required method of indentation.
> * I want to get it fixed before the branch is cut, which makes it easier to port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't do it.
> * I don't see it as very likely that we will back-port major fixes to this class on the 10.2 branch. If we have to, I will volunteer :)
> * Since so much else of the Clob "infrastructure" has changed recently, this seems like a good time to do the clean-up.
> Please raise your concern as soon as possible if you want to veto these changes.
> I do plan to commit them tomorrow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.