[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758622#comment-16758622 ] 

Hadoop QA commented on HBASE-14964:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  8s{color} | {color:red} HBASE-14964 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-14964 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12778270/HBASE-14964.1.branch-1.patch |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15843/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14964
>                 URL: https://issues.apache.org/jira/browse/HBASE-14964
>             Project: HBase
>          Issue Type: Improvement
>          Components: encryption
>            Reporter: Nate Edel
>            Assignee: Nate Edel
>            Priority: Minor
>             Fix For: 1.5.1
>
>         Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.1.branch-1.patch, HBASE-14964.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is a subset of that code in HFileReaderImpl.
> Refactored key selection 
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)