You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2026/06/27 23:20:39 UTC

[PR] JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle [netbeans]

matthiasblaesing opened a new pull request, #9472:
URL: https://github.com/apache/netbeans/pull/9472

   The primary motivation of this PR is moving the ssh support for JGIT from JSch to the Apache Mina based implementation. According to the JGIT project support for JSch is deprecated and there are no plans to move from the unmaintained version `com.jcraft:jsch` to `com.github.mwiede:jsch`.
   
   The move to the Mina based client is also required to enable SSH signing of commits.
   
   As preparation NetBinox, the one of the two OSGI implementations NetBeans currently offers, is dropped as it is essentially unmaintained.
   
   A second necessary preparation is to make JNA available as an OSGI bundle of the correct name. JNA was available to the OSGI environment via package imports, but the agent integration code of jgit declares a bundle requirement and thus needs the correct name. The current NetBeans module wrapper was dropped in favor of the raw JNA bundles (JNA und JNA-platform both declare OSGI metadata).
   
   Closes: #9471
   Closes: #7572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #9472:
URL: https://github.com/apache/netbeans/pull/9472#issuecomment-4844655596

   Only glanced at this.  Generally looks good, but I have concerns about all the changes to JNA.  I also wonder how many people are using JNA in the platform without an OSGi framework included.  Are there other ways of ensuring the right bundle name is seen from the NetBeans module?  Does using both manifest keys work (eg. `Bundle-SymbolicName` as well)???  Or adapt Netigso to also consider provides?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed pull request #9472: JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle
URL: https://github.com/apache/netbeans/pull/9472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists