[GitHub] [commons-collections] kinow commented on a change in pull request #178: fix ci builds

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #178:
URL: https://github.com/apache/commons-collections/pull/178#discussion_r477145595



##########
File path: .travis.yml
##########
@@ -29,10 +29,23 @@ jdk:
   - openjdk-ea
 
 script:
-  - mvn -V --no-transfer-progress
   # japicmp requires a package
-  - mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress
+  - |
+    if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+    then
+    mvn -V;
+    mvn -V jar:jar japicmp:cmp -P japicmp;
+    else
+    mvn -V --no-transfer-progress;
+    mvn -V jar:jar japicmp:cmp -P japicmp --no-transfer-progress;
+    fi;
 
 after_success:
   # jacoco will run in the main script. Include the profile to submit to coveralls.
-  - mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress
+  - |
+    if [ "$TRAVIS_JDK_VERSION" = "openjdk8" ];
+    then
+    mvn -V jacoco:report coveralls:report -Ptravis-jacoco;
+    else
+    mvn -V jacoco:report coveralls:report -Ptravis-jacoco --no-transfer-progress;
+    fi;

Review comment:
       Couldn't we just drop `--no-transfer-progress`? Having this in the CI scripts could cause some confusion in the next vote thread (we would either have to include instructions for people building on JDK8, or ask/hope them to check the CI scripts).
   
   If dropping it fixes, with the consequence that the logs may be a bit longer, then I think that should be OK. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org