You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 13:52:31 UTC
[GitHub] [spark] martin-g opened a new pull request #35555: [SPARK-38241][K8S] Close KubernetesClient in K8S integrations tests
martin-g opened a new pull request #35555:
URL: https://github.com/apache/spark/pull/35555
### What changes were proposed in this pull request?
Close org.apache.spark.deploy.k8s.integrationtest.backend.IntegrationTestBackend#getKubernetesClient in the `cleanUp()` of the backend implementations.
### Why are the changes needed?
It is a good practice to cleanup resources at the end of the tests, so they do not leak and affect other tests.
Recently I've noticed the following in the output:
```
===== POSSIBLE THREAD LEAK IN SUITE o.a.s.deploy.k8s.integrationtest.VolcanoSuite, threads: OkHttp [https://192.168.49.2:8443/.](https://192.168.49.2:8443/).. (daemon=false), scala-execution-context-global-26 (daemon=true), OkHttp ConnectionPool (daemon=true), scala-execution-context-global-24 (daemon=true), Okio Watchdog (daemon=true), scala-execution-context-global-23 (daemon=true), scala-execution-context-global-21 (daemon=true), scala-execution-context-global-22 (daemon=true), OkHttp WebSocket [https://192.168.49.2:8443/.](https://192.168.49.2:8443/).. (daemon=false), scala-execution-context-global-25 (daemon=true), scala-execution-context-global-20 (daemon=true) =====
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Run the IT tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35555: [SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35555:
URL: https://github.com/apache/spark/pull/35555#issuecomment-1043413312
BTW, Apache Spark community has a convention to use `[TESTS]` for test-only PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35555: [SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35555:
URL: https://github.com/apache/spark/pull/35555#issuecomment-1047390990
@dongjoon-hyun Thanks, it reasonable for careful at this stage.
@martin-g I also tested it in my k8s, it works, but the `POSSIBLE THREAD LEAK` info are also print after this patch, so we might need to update the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35555: [SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35555:
URL: https://github.com/apache/spark/pull/35555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35555: [SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35555:
URL: https://github.com/apache/spark/pull/35555#issuecomment-1044846858
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35555: [SPARK-38241][K8S][TESTS] Close KubernetesClient in K8S integrations tests
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35555:
URL: https://github.com/apache/spark/pull/35555#issuecomment-1047390990
@dongjoon-hyun Thanks, it reasonable for careful at this stage.
@martin-g I also tested it in my k8s, it works as expected, but the `POSSIBLE THREAD LEAK` info are also print after this patch, so we might need to update the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org