You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Yash Sharma <ya...@gmail.com> on 2014/04/18 16:33:51 UTC
Review Request 20486: New code gen implementation for Trigonometric math
functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/
-----------------------------------------------------------
Review request for drill, Jinfeng Ni and Mehant Baid.
Repository: drill-git
Description
-------
New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs
-----
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/20486/diff/
Testing
-------
Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
-----------------------------------------------
ACTUAL_RESULTS EXPECTED_RESULTS
-----------------------------------------------
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
-----------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Aditya Kishore <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41163
-----------------------------------------------------------
Ship it!
Ship It!
- Aditya Kishore
On April 23, 2014, 2:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 2:18 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testNewMathFunctions.json PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/
-----------------------------------------------------------
(Updated April 23, 2014, 9:18 a.m.)
Review request for drill, Jinfeng Ni and Mehant Baid.
Changes
-------
Patch cleanup and formatting
Repository: drill-git
Description
-------
New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs (updated)
-----
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/testNewMathFunctions.json PRE-CREATION
exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/20486/diff/
Testing
-------
Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
-----------------------------------------------
ACTUAL_RESULTS EXPECTED_RESULTS
-----------------------------------------------
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
-----------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/
-----------------------------------------------------------
(Updated April 23, 2014, 8:02 a.m.)
Review request for drill, Jinfeng Ni and Mehant Baid.
Changes
-------
Patch Formatting and merge.
Repository: drill-git
Description
-------
New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs (updated)
-----
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/testNewMathFunctions.json PRE-CREATION
exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/20486/diff/
Testing
-------
Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
-----------------------------------------------
ACTUAL_RESULTS EXPECTED_RESULTS
-----------------------------------------------
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
-----------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/
-----------------------------------------------------------
(Updated April 23, 2014, 7:37 a.m.)
Review request for drill, Jinfeng Ni and Mehant Baid.
Changes
-------
Implemented review comments by Mehant and Aditya.
Repository: drill-git
Description
-------
New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs (updated)
-----
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/20486/diff/
Testing
-------
Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
-----------------------------------------------
ACTUAL_RESULTS EXPECTED_RESULTS
-----------------------------------------------
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
-----------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
> On April 23, 2014, 1:11 a.m., Aditya Kishore wrote:
> > The patch introduces new trailing white-spaces and also contains TABs. Please convert TAB => "2 spaces" and get rid of trailing white-spaces **only in the new code**
Formatted patch.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41105
-----------------------------------------------------------
On April 23, 2014, 7:37 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:37 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Aditya Kishore <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41105
-----------------------------------------------------------
The patch introduces new trailing white-spaces and also contains TABs. Please convert TAB => "2 spaces" and get rid of trailing white-spaces **only in the new code**
- Aditya Kishore
On April 18, 2014, 7:34 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 7:34 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
> On April 23, 2014, 1:23 a.m., Aditya Kishore wrote:
> > exec/java-exec/src/main/codegen/data/MathFunc.tdd, line 182
> > <https://reviews.apache.org/r/20486/diff/1/?file=562159#file562159line182>
> >
> > Both 'outputType' and 'castType' can be moved to top level instead of being repeated for each types.
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41109
-----------------------------------------------------------
On April 18, 2014, 2:34 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 2:34 p.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Aditya Kishore <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41109
-----------------------------------------------------------
exec/java-exec/src/main/codegen/data/MathFunc.tdd
<https://reviews.apache.org/r/20486/#comment74519>
Both 'outputType' and 'castType' can be moved to top level instead of being repeated for each types.
- Aditya Kishore
On April 18, 2014, 7:34 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 7:34 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
> On April 23, 2014, 12:30 a.m., Mehant Baid wrote:
> > exec/java-exec/src/main/codegen/templates/MathFunctions.java, line 198
> > <https://reviews.apache.org/r/20486/diff/1/?file=562160#file562160line198>
> >
> > Do we need the cast here? The return type for the trignometric functions is double, so seems like the cast is unnecessary?
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41097
-----------------------------------------------------------
On April 23, 2014, 7:37 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:37 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/#review41097
-----------------------------------------------------------
Ship it!
exec/java-exec/src/main/codegen/templates/MathFunctions.java
<https://reviews.apache.org/r/20486/#comment74509>
Do we need the cast here? The return type for the trignometric functions is double, so seems like the cast is unnecessary?
- Mehant Baid
On April 18, 2014, 2:34 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20486/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 2:34 p.m.)
>
>
> Review request for drill, Jinfeng Ni and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
>
> These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
> The patch is also based on the parent patch for DRILL-247 ()
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
> exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20486/diff/
>
>
> Testing
> -------
>
> Yes.
> mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
>
> -----------------------------------------------
> ACTUAL_RESULTS EXPECTED_RESULTS
> -----------------------------------------------
> 0.8509035245341184 0.8509035245341184
> 0.5253219888177297 0.5253219888177297
> 1.6197751905438615 1.6197751905438615
> NaN NaN
> NaN NaN
> 1.5485777614681775 1.5485777614681775
> 1.7467135528742547E19 1.7467135528742547E19
> 1.7467135528742547E19 1.7467135528742547E19
> 1.0 1.0
> -----------------------------------------------
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31.391 s
> [INFO] Finished at: 2014-04-18T19:45:42+05:30
> [INFO] Final Memory: 53M/680M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 20486: New code gen implementation for Trigonometric math
functions
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20486/
-----------------------------------------------------------
(Updated April 18, 2014, 2:34 p.m.)
Review request for drill, Jinfeng Ni and Mehant Baid.
Repository: drill-git
Description
-------
New code gen implementation for Trigonometric math functions: sin, cos, tan, asin, acos, atan, sinh, cosh, tanh.
These can only be tested by directly submitting the Physical Plan since Optiq currently does not consider these.
The patch is also based on the parent patch for DRILL-247 ()
Diffs
-----
exec/java-exec/src/main/codegen/data/MathFunc.tdd 0ee94c2
exec/java-exec/src/main/codegen/templates/MathFunctions.java 66373f5
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/testTrigoMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/20486/diff/
Testing
-------
Yes.
mvn test -Dtest=TestNewMathFunctions#testTrigoMathFunc
-----------------------------------------------
ACTUAL_RESULTS EXPECTED_RESULTS
-----------------------------------------------
0.8509035245341184 0.8509035245341184
0.5253219888177297 0.5253219888177297
1.6197751905438615 1.6197751905438615
NaN NaN
NaN NaN
1.5485777614681775 1.5485777614681775
1.7467135528742547E19 1.7467135528742547E19
1.7467135528742547E19 1.7467135528742547E19
1.0 1.0
-----------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.755 sec - in org.apache.drill.exec.fn.impl.TestNewMathFunctions
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31.391 s
[INFO] Finished at: 2014-04-18T19:45:42+05:30
[INFO] Final Memory: 53M/680M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma