You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 12:26:27 UTC

[GitHub] [spark] deshanxiao opened a new pull request #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

deshanxiao opened a new pull request #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647
 
 
   ### What changes were proposed in this pull request?
   The java api setWritable,setReadable and setExecutable dosen't work well because root can read / write or execute every files. Maybe, we could cancel these tests or fast failure when the mvn test is starting.
   
   
   ### Why are the changes needed?
   When we run the test in root role, the test will fail.
   ```
   SPARK-3697: ignore files that cannot be read. *** FAILED ***
     2 was not equal to 1 (FsHistoryProviderSuite.scala:187)
   - temporary shuffle/local file should be able to handle disk failures *** FAILED ***
     tempShuffleFile3.exists() was true All disks are broken, so there should be no temp shuffle file created (DiskBlockManagerSuite.scala:124)
   ```
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-588997475
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-588997061
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] jiangxb1987 edited a comment on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
jiangxb1987 edited a comment on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-590561924
 
 
   Do you have an easy way to do it? I don't think it's worthy to add more complexity to ensure that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-589165850
 
 
   Yeah, don't run as root. This is a good example of why - it defeats the purpose of a few of the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-588997061
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] jiangxb1987 commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-590561924
 
 
   Do you have an easy way to do it? I don't think it's worth to add more complexity to ensure that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] jiangxb1987 commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-589442525
 
 
   Agree with Sean, you should avoid running test cases as the root user.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-589164684
 
 
   @srowen  Sure, running tests as root is not a good idea. I run my tests in gitlab ci/cd. Root is its default user. Maybe, it's not bad to cancel these tests. Or just disable root to run all tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work

Posted by GitBox <gi...@apache.org>.
deshanxiao commented on issue #27647: [SPARK-30883][TEST] Cancel the tests when setReadable and setExecutable don't work
URL: https://github.com/apache/spark/pull/27647#issuecomment-589923654
 
 
   I agree. Is it necessary to add some code to prevent running as root? @jiangxb1987 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org