You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2009/07/07 08:54:53 UTC

[DISCUSSION / VOTE] - remove @author tags in code

Hi

I want to propose that we remove the @author tags in the source code
for Apache Camel.
We only have about 20 files with author tags and for 2 persons.

As I understand its not common at Apache to have @author tags in the
source code.

Here is my +1 to remove them


-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Jon Anstey <ja...@gmail.com>.
+1

On Tue, Jul 7, 2009 at 4:24 AM, Claus Ibsen <cl...@gmail.com> wrote:

> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>



-- 
Cheers,
Jon

http://janstey.blogspot.com/

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Roman Kalukiewicz <ro...@gmail.com>.
Usually @author tag shows the class creator - not the actual
maintainer of the class. Of course one person can have both roles, but
in general I believe it is useless for Camel. My +1

Roman

2009/7/7 Claus Ibsen <cl...@gmail.com>:
> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Hadrian Zbarcea <hz...@gmail.com>.
I hope I didn't jump the gun here, but given the consenus:
https://issues.apache.org/activemq/browse/CAMEL-1812

+1
Hadrian


On Jul 7, 2009, at 2:54 AM, Claus Ibsen wrote:

> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them
>
>
> -- 
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus


Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by David Jencks <da...@yahoo.com>.
Not that I'm an active contributor, but I find @author tags only  
annoying....   +1 to removing them.

david jencks

On Jul 6, 2009, at 11:54 PM, Claus Ibsen wrote:

> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them
>
>
> -- 
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by James Strachan <ja...@gmail.com>.
2009/7/7 Bruce Snyder <br...@gmail.com>:
> On Tue, Jul 7, 2009 at 12:54 AM, Claus Ibsen<cl...@gmail.com> wrote:
>> Hi
>>
>> I want to propose that we remove the @author tags in the source code
>> for Apache Camel.
>> We only have about 20 files with author tags and for 2 persons.
>>
>> As I understand its not common at Apache to have @author tags in the
>> source code.
>>
>> Here is my +1 to remove them

+1.

Its silly to have just 20 files out of zillions with author tags. Plus
the code is all ours rather than a certain individual. (Plus I've
found you tend to get emailed directly when things go wrong rather
than folks using the mailing lists!)

> This is always decided on a project-by-project basis at the ASF. There
> is no policy that disallows them at all. In fact, I find them very
> useful to know who has worked on a given class and therefore I prefer
> them.

They are rarely accurate. You can use the svn log to find out who
really worked on a file. Even in the rare cases of things moving (e.g.
incubation) its quite easy to track where a file originated from.


-- 
James
-------
http://macstrac.blogspot.com/

Open Source Integration
http://fusesource.com/

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Bruce Snyder <br...@gmail.com>.
On Tue, Jul 7, 2009 at 12:54 AM, Claus Ibsen<cl...@gmail.com> wrote:
> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them

This is always decided on a project-by-project basis at the ASF. There
is no policy that disallows them at all. In fact, I find them very
useful to know who has worked on a given class and therefore I prefer
them. Not having them winds up being a big pain in the ass, especially
if the code base gets moved around at all and history is lost (see
ActiveMQ). I won't go so far at to -1 the removal yet. I'll wait to
see what others have to say.

Bruce
-- 
perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*"
);'

ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bruceblog.org/
Twitter: http://twitter.com/brucesnyder

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by William Tam <em...@gmail.com>.
+1 for removing.



On Tue, Jul 7, 2009 at 3:47 AM, Willem Jiang<wi...@gmail.com> wrote:
> +1 for this.
> Since it's open source project, anyone can have the right to modify the
> code, we should encourage people to do it :)
>
> Willem
>
> Claus Ibsen wrote:
>>
>> Hi
>>
>> I want to propose that we remove the @author tags in the source code
>> for Apache Camel.
>> We only have about 20 files with author tags and for 2 persons.
>>
>> As I understand its not common at Apache to have @author tags in the
>> source code.
>>
>> Here is my +1 to remove them
>>
>>
>
>

Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Willem Jiang <wi...@gmail.com>.
+1 for this.
Since it's open source project, anyone can have the right to modify the 
code, we should encourage people to do it :)

Willem

Claus Ibsen wrote:
> Hi
> 
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
> 
> As I understand its not common at Apache to have @author tags in the
> source code.
> 
> Here is my +1 to remove them
> 
> 


Re: [DISCUSSION / VOTE] - remove @author tags in code

Posted by Charles Moulliard <cm...@gmail.com>.
+1

Charles Moulliard
Senior Enterprise Architect
Apache Camel Committer

*****************************
blog : http://cmoulliard.blogspot.com


On Tue, Jul 7, 2009 at 8:54 AM, Claus Ibsen <cl...@gmail.com> wrote:

> Hi
>
> I want to propose that we remove the @author tags in the source code
> for Apache Camel.
> We only have about 20 files with author tags and for 2 persons.
>
> As I understand its not common at Apache to have @author tags in the
> source code.
>
> Here is my +1 to remove them
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>