You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/09/29 20:37:28 UTC

[GitHub] [drill] pjfanning opened a new pull request, #2665: DRILL-8324: sizeof refactor

pjfanning opened a new pull request, #2665:
URL: https://github.com/apache/drill/pull/2665

   ## Description
   
   Remove use java-sizeof jar. It is an old copy of Spark code. I have ported the latest Spark code to Java and inlined it.
   
   ## Documentation
   (Please describe user-visible changes similar to what should appear in the Drill documentation.)
   
   ## Testing
   (Please describe how this PR has been tested.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] pjfanning commented on pull request #2665: DRILL-8324: sizeof refactor

Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #2665:
URL: https://github.com/apache/drill/pull/2665#issuecomment-1268917234

   @cgivre My PR uses the latest Spark code for the SizeEstimator as opposed to very old copy of the Spark code that was copied and not maintained in java-sizeof lib. The new code gives slightly higher estimates for object instance sizes. Would this be an issue? 
   
   Also, with tests - Spark and the java-sizeof lib use some Scala based tests - and they are not that easily replicated in Java. The question is whether the tests that I've added in this PR or if I need more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] cgivre commented on pull request #2665: DRILL-8324: sizeof refactor

Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2665:
URL: https://github.com/apache/drill/pull/2665#issuecomment-1279887012

   > 
   
   Given that this only affects the OpenTSDB plugin, I think it is fine.  I've honestly never even heard of anyone actually using that with Drill. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [drill] cgivre merged pull request #2665: DRILL-8324: sizeof refactor

Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2665:
URL: https://github.com/apache/drill/pull/2665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org