[GitHub] [incubator-gobblin] krishraman commented on a change in pull request #2706: Emit WorkUnitsCreated Count Event for MR deployed jobs.

[GitBox <gi...@apache.org>]

krishraman commented on a change in pull request #2706: Emit WorkUnitsCreated Count Event for MR deployed jobs. 
URL: https://github.com/apache/incubator-gobblin/pull/2706#discussion_r313702199
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
 ##########
 @@ -262,6 +265,10 @@ protected void runWorkUnits(List<WorkUnit> workUnits) throws Exception {
     JobState jobState = this.jobContext.getJobState();
 
     try {
+      CountEventBuilder countEventBuilder = new CountEventBuilder(JobEvent.WORK_UNITS_CREATED, workUnits.size());
 
 Review comment:
   Updated the RB with changes. 
   1) For Local Job launcher I had to iterate the workunit stream as it's not possible to get the count without materializing the wu. 
   2) For helix there could be a check for "emtpy" workUnits event and return but I am not sure the caller does the check/or logic guarantees wu's.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services