[jira] Resolved: (MAHOUT-100) MySQLJDBCDiffStorage should use preferenceTable, userIDColumn, etc. from MySQLJDBCDataModel

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAHOUT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved MAHOUT-100.
------------------------------

    Resolution: Fixed
      Assignee: Sean Owen

I like it. I just committed a somewhat bigger change that addresses the same point.

> MySQLJDBCDiffStorage should use preferenceTable, userIDColumn, etc. from MySQLJDBCDataModel
> -------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-100
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-100
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>            Reporter: Jens Grivolla
>            Assignee: Sean Owen
>            Priority: Minor
>
> The constructor of MySQLJDBCDiffStorage should use the appropriate values from the corresponding DataModel, instead of the defaults from AbstractJDBCDataModel.
> Proposed fix:
> in MySQLJDBCDataModel.java (line numbers may be off):
> 80a82,86
> >   private String preferenceTable;
> >   private String userIDColumn;
> >   private String itemIDColumn;
> >   private String preferenceColumn;
> > 
> 163a170,189
> >     this.preferenceTable = preferenceTable;
> >     this.userIDColumn = userIDColumn;
> >     this.itemIDColumn = itemIDColumn;
> >     this.preferenceColumn = preferenceColumn;
> >   }
> > 
> >   public String getPreferenceTable() {
> >     return preferenceTable;
> >   }
> > 
> >   public String getUserIDColumn() {
> >     return userIDColumn;
> >   }
> > 
> >   public String getItemIDColumn() {
> >     return itemIDColumn;
> >   }
> > 
> >   public String getPreferenceColumn() {
> >     return preferenceColumn;
> in MySQLJDBCDiffStorage.java:
> 61,64c61,64
> <          AbstractJDBCDataModel.DEFAULT_PREFERENCE_TABLE,
> <          AbstractJDBCDataModel.DEFAULT_USER_ID_COLUMN,
> <          AbstractJDBCDataModel.DEFAULT_ITEM_ID_COLUMN,
> <          AbstractJDBCDataModel.DEFAULT_PREFERENCE_COLUMN,
> ---
> >          dataModel.getPreferenceTable(),
> >          dataModel.getUserIDColumn(),
> >          dataModel.getItemIDColumn(),
> >          dataModel.getPreferenceColumn(),

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.