[GitHub] merlimat commented on a change in pull request #857: Introduce auto bundle split and unloading of split bundle in ModularLoadManager

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #857: Introduce auto bundle split and unloading of split bundle in ModularLoadManager
URL: https://github.com/apache/incubator-pulsar/pull/857#discussion_r146753292
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/Namespaces.java
 ##########
 @@ -838,7 +838,8 @@ public void unloadNamespaceBundle(@PathParam("property") String property, @PathP
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission") })
     public void splitNamespaceBundle(@PathParam("property") String property, @PathParam("cluster") String cluster,
             @PathParam("namespace") String namespace, @PathParam("bundle") String bundleRange,
-            @QueryParam("authoritative") @DefaultValue("false") boolean authoritative) {
+            @QueryParam("authoritative") @DefaultValue("false") boolean authoritative,
+            @QueryParam("unload") @DefaultValue("false") boolean unload) {
 
 Review comment:
   Since the brokers already have the `loadBalancerAutoUnloadSplitBundlesEnabled` parameter, wouldn't this `unload` option be redundant? 
   
   Just trigger the split and broker will decide whether to unload or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services