You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/10 08:02:10 UTC
[kudu-CR] webserver: tag webserver require spnego as stable
Hello Andrew Wong, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14872
to review the following change.
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
webserver: tag webserver_require_spnego as stable
This is a pretty important piece of "secure" web UI puzzle, and I don't
expect its interface to change in the future.
I also snuck in a change to add webserver_require_spnego to the security
section of /config. Screenshot: https://imgur.com/a/jdDO28I
Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/webserver_options.cc
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/14872/1
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14872 )
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Dec 2019 15:25:19 +0000
Gerrit-HasComments: No
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14872 )
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14872 )
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
Patch Set 2: Verified+1
Another unrelated "can't find wheel" python error. Will investigate further.
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Dec 2019 18:33:40 +0000
Gerrit-HasComments: No
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14872 )
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Dec 2019 16:13:43 +0000
Gerrit-HasComments: No
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14872 )
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
webserver: tag webserver_require_spnego as stable
This is a pretty important piece of "secure" web UI puzzle, and I don't
expect its interface to change in the future.
I also snuck in a change to add webserver_require_spnego to the security
section of /config. Screenshot: https://imgur.com/a/jdDO28I
Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Reviewed-on: http://gerrit.cloudera.org:8080/14872
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/webserver_options.cc
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] webserver: tag webserver require spnego as stable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14872
to look at the new patch set (#2).
Change subject: webserver: tag webserver_require_spnego as stable
......................................................................
webserver: tag webserver_require_spnego as stable
This is a pretty important piece of "secure" web UI puzzle, and I don't
expect its interface to change in the future.
I also snuck in a change to add webserver_require_spnego to the security
section of /config. Screenshot: https://imgur.com/a/jdDO28I
Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/webserver_options.cc
2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/14872/2
--
To view, visit http://gerrit.cloudera.org:8080/14872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib223431f037dfa9f4c9e3d03b03ce03555b25de7
Gerrit-Change-Number: 14872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)