You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (Created) (JIRA)" <ji...@apache.org> on 2011/10/20 06:42:11 UTC
[jira] [Created] (HIVE-2517) Support group by on union and struct
type
Support group by on union and struct type
-----------------------------------------
Key: HIVE-2517
URL: https://issues.apache.org/jira/browse/HIVE-2517
Project: Hive
Issue Type: New Feature
Components: Query Processor
Reporter: Ashutosh Chauhan
Attachments: hive-2517.patch
Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Status: Patch Available (was: Open)
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Fix For: 0.9.0
>
> Attachments: HIVE-2517.D2151.1.patch, hive-2517.patch, hive-2517_1.patch, hive-2517_2.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Attachment: hive-2517.patch
Patch which enables this support. Test cases included.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Status: Patch Available (was: Open)
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Fix Version/s: (was: 0.9.0)
Unlinking from 0.9
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Attachments: HIVE-2517.D2151.1.patch, hive-2517.patch, hive-2517_1.patch, hive-2517_2.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Fix Version/s: 0.9.0
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Fix For: 0.9.0
>
> Attachments: hive-2517.patch, hive-2517_1.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan reassigned HIVE-2517:
--------------------------------------
Assignee: Ashutosh Chauhan
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138588#comment-13138588 ]
Ashutosh Chauhan commented on HIVE-2517:
----------------------------------------
Any one care to take a look at this one?
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch, hive-2517_1.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2517:
---------------------------------
Status: Open (was: Patch Available)
@Ashutosh: Patch needs to be rebased on trunk. Also, can you please submit a review request on phabricator? Thanks.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Fix For: 0.9.0
>
> Attachments: hive-2517.patch, hive-2517_1.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2517) Support group by on union and struct
type
Posted by "Philip Tromans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428152#comment-13428152 ]
Philip Tromans commented on HIVE-2517:
--------------------------------------
Hi,
Can we bump this please? I just came up against this issue, wrote the patch, was about to submit it, only to find it already here...
Cheers.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Attachments: HIVE-2517.D2151.1.patch, hive-2517.patch, hive-2517_1.patch, hive-2517_2.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Attachment: hive-2517_2.patch
Patch with license.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Fix For: 0.9.0
>
> Attachments: HIVE-2517.D2151.1.patch, hive-2517.patch, hive-2517_1.patch, hive-2517_2.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2517:
------------------------------
Attachment: HIVE-2517.D2151.1.patch
ashutoshc requested code review of "HIVE-2517 [jira] Support group by on union and struct type".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2517
Rebased to trunk.
Currently group by on struct and union types are not supported. This issue will enable support for those.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2151
AFFECTED FILES
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
ql/src/test/results/clientpositive/groupby_complex_types.q.out
ql/src/test/queries/clientpositive/groupby_complex_types.q
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4713/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Fix For: 0.9.0
>
> Attachments: HIVE-2517.D2151.1.patch, hive-2517.patch, hive-2517_1.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2517:
-----------------------------------
Attachment: hive-2517_1.patch
I think it doesn't make sense to do a group by on union data type since what data type it contains varies on row by row basis. This is same as I have pointed on HIVE-2508 So, I have stripped off bits on union type from this patch. I have left hash code still in there because its useful for GenericUDFHash().
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch, hive-2517_1.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2517) Support group by on union and struct
type
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131368#comment-13131368 ]
jiraposter@reviews.apache.org commented on HIVE-2517:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2459/
-----------------------------------------------------------
Review request for hive, John Sichi, Yongqiang He, Ning Zhang, and namit jain.
Summary
-------
Support for grouping on union and struct type.
This addresses bug HIVE-2517.
https://issues.apache.org/jira/browse/HIVE-2517
Diffs
-----
trunk/ql/src/test/queries/clientpositive/groupby_complex_types.q 1186610
trunk/ql/src/test/results/clientpositive/groupby_complex_types.q.out 1186610
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java 1186610
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 1186610
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUnion.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java 1186610
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java 1186610
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryUnionObjectInspector.java PRE-CREATION
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1186610
Diff: https://reviews.apache.org/r/2459/diff
Testing
-------
Added *.q tests
Thanks,
Ashutosh
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2517.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2517) Support group by on union and struct
type
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448899#comment-13448899 ]
Ashutosh Chauhan commented on HIVE-2517:
----------------------------------------
@Philip : Certainly. Since I wrote the patch I cant check this in. If some other committer volunteers to help, then we can get this in.
> Support group by on union and struct type
> -----------------------------------------
>
> Key: HIVE-2517
> URL: https://issues.apache.org/jira/browse/HIVE-2517
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Labels: structtype, uniontype
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2517.D2151.1.patch, hive-2517_1.patch, hive-2517_2.patch, hive-2517.patch
>
>
> Currently group by on struct and union types are not supported. This issue will enable support for those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira