You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by sudheeshkatkam <gi...@git.apache.org> on 2016/02/01 22:11:07 UTC

[GitHub] drill pull request: DRILL-4069: Enable RPC thread offload by defau...

GitHub user sudheeshkatkam opened a pull request:

    https://github.com/apache/drill/pull/352

    DRILL-4069: Enable RPC thread offload by default

    https://github.com/apache/drill/commit/43414e1e2731c85a52febaaedebfa2f392dd6d2f removes the usage of recyclers for RequestEvent and ResponseEvent in the RPC layer. This change resolves functional regressions mentioned in [DRILL-4041](https://issues.apache.org/jira/browse/DRILL-4041) and [DRILL-4057](https://issues.apache.org/jira/browse/DRILL-4057).
    
    Multiple test runs with the same setup mentioned in the tickets did not show any regressions.
    
    @jacques-n can you please review?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-4069

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit f2d42074d64d2146eb15bee2374edf78864f832e
Author: Sudheesh Katkam <sk...@maprtech.com>
Date:   2016-01-22T21:12:50Z

    DRILL-4069: Enable RPC thread offload by default

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4069: Enable RPC thread offload by defau...

Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:

    https://github.com/apache/drill/pull/352#issuecomment-191349592
  
    All unit tests and regression tests "passed". However, in the logs, I saw TestFragmentExecutorCancel failed to cleanup properly. When I try to debug the issue, there is no problem. So it seems like there is a timing issue. I will try other means, and post an update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4069: Enable RPC thread offload by defau...

Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/352#issuecomment-178199199
  
    LGTM. +1
    
    Nice (but strange) that this resolves the other issues.
    
    I wonder if the local channel short circuit would work now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---