You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/08/14 07:41:40 UTC

[GitHub] [incubator-celeborn] zwangsheng commented on pull request #1811: [CELEBORN-888][WORKER]Tweak the logic and add unit tests for the MemoryManager#currentServingState method

zwangsheng commented on PR #1811:
URL: https://github.com/apache/incubator-celeborn/pull/1811#issuecomment-1676831813

   > > Make this method logical ...
   > 
   > Any details? What problem do you find in the current implementation?
   
   The main thing is to add unit tests to ensure that this piece of logic is changed by mistake.
   
   The modification of the method is to reduce judgments and avoid making unnecessary comparisons before the method returns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org