You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by Roger Meier <ro...@bufferoverflow.ch> on 2010/07/09 02:07:07 UTC

Coding Guidelines & Enumerations

Hi all

is there a coding style manual for Thrift contributers?

I was looking for a CodeStyle inside Source, Wiki, etc. and did not 
found anything.
e.g.
C++ => boost style, facebook?
Java: http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
JavaScript: http://javascript.crockford.com/code.html

Another question is...
Why are there no enumaration for protocol and transport types?

Thanks

Roger

Re: Coding Guidelines & Enumerations

Posted by Roger Meier <ro...@bufferoverflow.ch>.

Thanks Bryan!

I like the implicit set of guidelines!
reducing doc stuff and focusing on code.

I've added the Enumeration Topics as a Improvement via JIRA:
	add Enumeration for protocol, transport and server types
	https://issues.apache.org/jira/browse/THRIFT-819

Roger


Am 13.07.2010 18:22, schrieb Bryan Duxbury:
> Roger -
>
> We don't have any "official" coding style guidelines, though I'd say pretty
> much every library (and the compiler) have an implicit set of guidelines
> they follow.
>
> As far as having an enumeration for protocol and transport types: Do you
> mean some code construct that identifies them all, or just some wiki page?
> In either case, I'd suggest you open a ticket in JIRA for us to create what
> it is you're looking for.
>
> -Bryan
>
> On Thu, Jul 8, 2010 at 5:07 PM, Roger Meier<ro...@bufferoverflow.ch>  wrote:
>
>> Hi all
>>
>> is there a coding style manual for Thrift contributers?
>>
>> I was looking for a CodeStyle inside Source, Wiki, etc. and did not found
>> anything.
>> e.g.
>> C++ =>  boost style, facebook?
>> Java: http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
>> JavaScript: http://javascript.crockford.com/code.html
>>
>> Another question is...
>> Why are there no enumaration for protocol and transport types?
>>
>> Thanks
>>
>> Roger
>>
>>
>

Re: Coding Guidelines & Enumerations

Posted by Bryan Duxbury <br...@rapleaf.com>.

Roger -

We don't have any "official" coding style guidelines, though I'd say pretty
much every library (and the compiler) have an implicit set of guidelines
they follow.

As far as having an enumeration for protocol and transport types: Do you
mean some code construct that identifies them all, or just some wiki page?
In either case, I'd suggest you open a ticket in JIRA for us to create what
it is you're looking for.

-Bryan

On Thu, Jul 8, 2010 at 5:07 PM, Roger Meier <ro...@bufferoverflow.ch> wrote:

> Hi all
>
> is there a coding style manual for Thrift contributers?
>
> I was looking for a CodeStyle inside Source, Wiki, etc. and did not found
> anything.
> e.g.
> C++ => boost style, facebook?
> Java: http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
> JavaScript: http://javascript.crockford.com/code.html
>
> Another question is...
> Why are there no enumaration for protocol and transport types?
>
> Thanks
>
> Roger
>
>