You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/06/22 14:35:33 UTC
[GitHub] qpid-dispatch pull request #327: DISPATCH-1041 - Add tests to validate each ...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/327
DISPATCH-1041 - Add tests to validate each global delivery count accu…
…rately
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1041
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #327
----
commit 4c9e6d934e406d18ef2127f859652e6d5618a2b9
Author: Ganesh Murthy <gm...@...>
Date: 2018-06-22T14:34:10Z
DISPATCH-1041 - Add tests to validate each global delivery count accurately
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...
Posted by fgiorgetti <gi...@git.apache.org>.
Github user fgiorgetti commented on the issue:
https://github.com/apache/qpid-dispatch/pull/327
It covers everything now!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/327
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=h1) Report
> Merging [#327](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/2e766f35cf2b3a172aaa58cef6c996376e69f1c9?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 86.52% 86.54% +0.01%
==========================================
Files 69 69
Lines 15479 15479
==========================================
+ Hits 13393 13396 +3
+ Misses 2086 2083 -3
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.57% <0%> (+0.14%)` | :arrow_up: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.25% <0%> (+0.37%)` | :arrow_up: |
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/327/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=footer). Last update [2e766f3...4c9e6d9](https://codecov.io/gh/apache/qpid-dispatch/pull/327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #327: DISPATCH-1041 - Add tests to validate each ...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/327
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...
Posted by fgiorgetti <gi...@git.apache.org>.
Github user fgiorgetti commented on the issue:
https://github.com/apache/qpid-dispatch/pull/327
@ganeshmurthy it looks great to me. One thing I noticed is that the only new metric that is not present in this test is: "acceptedDeliveries". But I see it being used in system_tests_one_router.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #327: DISPATCH-1041 - Add tests to validate each global ...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on the issue:
https://github.com/apache/qpid-dispatch/pull/327
Good catch. Not sure how I missed that. I will add anew test for acceptedDeliveries and will let you know
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org