You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/20 03:14:48 UTC

[GitHub] [superset] robdiciuccio commented on a change in pull request #12103: fix(async queries): Remove "force" param on cached data retrieval

robdiciuccio commented on a change in pull request #12103:
URL: https://github.com/apache/superset/pull/12103#discussion_r560646690



##########
File path: superset/common/query_context.py
##########
@@ -60,8 +60,8 @@ class QueryContext:
     queries: List[QueryObject]
     force: bool
     custom_cache_timeout: Optional[int]
-    result_type: utils.ChartDataResultType
-    result_format: utils.ChartDataResultFormat
+    result_type: Union[utils.ChartDataResultType, str]
+    result_format: Union[utils.ChartDataResultFormat, str]

Review comment:
       I was able to get `marshmallow_enum` working, so the `Union` is no longer necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org