You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Chris Teoh <ch...@gmail.com> on 2018/08/13 10:52:29 UTC
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------
(Updated Aug. 13, 2018, 8:52 p.m.)
Review request for Sqoop.
Changes
-------
Updated based on feedback.
Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224
Repository: sqoop-trunk
Description
-------
Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
Diffs (updated)
-----
build.xml 084823cf
src/docs/user/import-mainframe.txt abeb7cde
src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java 9b277b2a
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java be62efd0
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/20/
Changes: https://reviews.apache.org/r/62492/diff/19-20/
Testing
-------
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Szabolcs Vasas <va...@gmail.com>.
> On Aug. 17, 2018, 12:56 p.m., Szabolcs Vasas wrote:
> > Hi Chris,
> >
> > Thank you for the improvements, I have not found any major issues with your patch, so I think if you fix the below small things we will be good to go.
> >
> > Thanks,
> > Szabolcs
And I have ran the test and third party tests successfully with your patch.
- Szabolcs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207485
-----------------------------------------------------------
On Aug. 13, 2018, 10:52 a.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62492/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3224
> https://issues.apache.org/jira/browse/SQOOP-3224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
>
>
> Diffs
> -----
>
> build.xml 084823cf
> src/docs/user/import-mainframe.txt abeb7cde
> src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
> src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
> src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
> src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
> src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
> src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
> src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
> src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
> src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java 9b277b2a
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java be62efd0
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
> src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
>
>
> Diff: https://reviews.apache.org/r/62492/diff/20/
>
>
> Testing
> -------
>
> Unit tests.
>
> Functional testing on mainframe.
>
>
> Thanks,
>
> Chris Teoh
>
>
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Chris Teoh <ch...@gmail.com>.
> On Aug. 17, 2018, 10:56 p.m., Szabolcs Vasas wrote:
> > Hi Chris,
> >
> > Thank you for the improvements, I have not found any major issues with your patch, so I think if you fix the below small things we will be good to go.
> >
> > Thanks,
> > Szabolcs
>
> Szabolcs Vasas wrote:
> And I have ran the test and third party tests successfully with your patch.
Thanks for your time to review Szabolcs. I have updated the patch based on your review. Please let me know if there are further changes.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207485
-----------------------------------------------------------
On Aug. 13, 2018, 8:52 p.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62492/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 8:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3224
> https://issues.apache.org/jira/browse/SQOOP-3224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
>
>
> Diffs
> -----
>
> build.xml 084823cf
> src/docs/user/import-mainframe.txt abeb7cde
> src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
> src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
> src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
> src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
> src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
> src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
> src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
> src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
> src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java 9b277b2a
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java be62efd0
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
> src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
>
>
> Diff: https://reviews.apache.org/r/62492/diff/20/
>
>
> Testing
> -------
>
> Unit tests.
>
> Functional testing on mainframe.
>
>
> Thanks,
>
> Chris Teoh
>
>
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207485
-----------------------------------------------------------
Hi Chris,
Thank you for the improvements, I have not found any major issues with your patch, so I think if you fix the below small things we will be good to go.
Thanks,
Szabolcs
src/java/org/apache/sqoop/SqoopOptions.java
Lines 34 (patched)
<https://reviews.apache.org/r/62492/#comment290886>
Unused import, please remove it.
src/java/org/apache/sqoop/tool/MainframeImportTool.java
Line 74 (original)
<https://reviews.apache.org/r/62492/#comment290885>
This is an unrelated whitespace change, please restore the original state.
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java
Lines 46 (patched)
<https://reviews.apache.org/r/62492/#comment290888>
I don't see any other changes in this class so please restore its original state.
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java
Line 24 (original)
<https://reviews.apache.org/r/62492/#comment290889>
I don't see any other change in this class so please restore the original state.
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java
Line 27 (original)
<https://reviews.apache.org/r/62492/#comment290890>
I don't see any other change in this class so please restore the original state.
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java
Lines 22 (patched)
<https://reviews.apache.org/r/62492/#comment290887>
Unused import.
- Szabolcs Vasas
On Aug. 13, 2018, 10:52 a.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62492/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 10:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3224
> https://issues.apache.org/jira/browse/SQOOP-3224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
>
>
> Diffs
> -----
>
> build.xml 084823cf
> src/docs/user/import-mainframe.txt abeb7cde
> src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
> src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
> src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
> src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
> src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
> src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
> src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
> src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
> src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java 9b277b2a
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java be62efd0
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
> src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
>
>
> Diff: https://reviews.apache.org/r/62492/diff/20/
>
>
> Testing
> -------
>
> Unit tests.
>
> Functional testing on mainframe.
>
>
> Thanks,
>
> Chris Teoh
>
>
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207667
-----------------------------------------------------------
Fix it, then Ship it!
Hi Chris,
Thank you for improving your patch!
I have some very minor findings regarding the latest version otherwise it LGTM in general, the tests passed too.
Thanks,
Bogi
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java
Line 40 (original)
<https://reviews.apache.org/r/62492/#comment291154>
Seems to be an unnecessary line deletion, this file doesn't contain anz other relevant change. Please revert.
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java
Line 51 (original)
<https://reviews.apache.org/r/62492/#comment291155>
Seems to be an unnecessary line deletion, this file doesn't contain anz other relevant change. Please revert.
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java
Lines 46-47 (patched)
<https://reviews.apache.org/r/62492/#comment291251>
Unnecessary new lines, there is no other change in this file, please revert.
- Boglarka Egyed
On Aug. 17, 2018, 1:39 p.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62492/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 1:39 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3224
> https://issues.apache.org/jira/browse/SQOOP-3224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
>
>
> Diffs
> -----
>
> build.xml 084823cf
> src/docs/user/import-mainframe.txt abeb7cde
> src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
> src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
> src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
> src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
> src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
> src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
> src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
> src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
> src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
>
>
> Diff: https://reviews.apache.org/r/62492/diff/21/
>
>
> Testing
> -------
>
> Unit tests.
>
> Functional testing on mainframe.
>
>
> Thanks,
>
> Chris Teoh
>
>
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/#review207814
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On Aug. 23, 2018, 9:51 a.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62492/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 9:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3224
> https://issues.apache.org/jira/browse/SQOOP-3224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
>
>
> Diffs
> -----
>
> build.xml 084823cf
> src/docs/user/import-mainframe.txt abeb7cde
> src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
> src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
> src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
> src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
> src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
> src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
> src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
> src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
>
>
> Diff: https://reviews.apache.org/r/62492/diff/22/
>
>
> Testing
> -------
>
> Unit tests.
>
> Functional testing on mainframe.
>
>
> Thanks,
>
> Chris Teoh
>
>
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Chris Teoh <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 7:51 p.m.)
Review request for Sqoop.
Changes
-------
Based on feedback.
Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224
Repository: sqoop-trunk
Description
-------
Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
Diffs (updated)
-----
build.xml 084823cf
src/docs/user/import-mainframe.txt abeb7cde
src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
Diff: https://reviews.apache.org/r/62492/diff/22/
Changes: https://reviews.apache.org/r/62492/diff/21-22/
Testing
-------
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should
have an option to use binary mode for transfer
Posted by Chris Teoh <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 11:39 p.m.)
Review request for Sqoop.
Changes
-------
Updated based on feedback.
Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224
Repository: sqoop-trunk
Description
-------
Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
Diffs (updated)
-----
build.xml 084823cf
src/docs/user/import-mainframe.txt abeb7cde
src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf
src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8
src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59
src/java/org/apache/sqoop/tool/ImportTool.java 478f1748
src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78
src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
Diff: https://reviews.apache.org/r/62492/diff/21/
Changes: https://reviews.apache.org/r/62492/diff/20-21/
Testing
-------
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh