You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2026/09/22 15:06:47 UTC
[PR] Allow a Job to be associated with several teams [airflow]
vincbeck opened a new pull request, #73561:
URL: https://github.com/apache/airflow/pull/73561
A Job's team scope was a single nullable column, which cannot describe a Dag processor that parses bundles belonging to more than one team.
There is no breaking change here, adding `team` as part of the job API response has not been released yet. Also, this is related to multi-team, which is still experimental.
Raised in review of #73295.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a Job to be associated with several teams [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #73561:
URL: https://github.com/apache/airflow/pull/73561#discussion_r4086477358
##########
airflow-core/src/airflow/api/common/airflow_health.py:
##########
@@ -168,7 +168,12 @@ def _triggerer_detailed_status(jobs: list[Job]) -> DetailedHealthStatus:
if not expected:
return _liveness_status(jobs)
- return _coverage_status(expected, {job.team_name for job in jobs if job.is_alive()})
+ covered: set[str | None] = set()
+ for job in jobs:
+ if job.is_alive():
+ # An unscoped triggerer serves exactly the team-less scope, which ``expected`` spells ``None``.
Review Comment:
Dont you talk AI? Kidding, I agree, this is not clear at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a Job to be associated with several teams [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #73561:
URL: https://github.com/apache/airflow/pull/73561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a Job to be associated with several teams [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #73561:
URL: https://github.com/apache/airflow/pull/73561#discussion_r4086371173
##########
airflow-core/src/airflow/api/common/airflow_health.py:
##########
@@ -168,7 +168,12 @@ def _triggerer_detailed_status(jobs: list[Job]) -> DetailedHealthStatus:
if not expected:
return _liveness_status(jobs)
- return _coverage_status(expected, {job.team_name for job in jobs if job.is_alive()})
+ covered: set[str | None] = set()
+ for job in jobs:
+ if job.is_alive():
+ # An unscoped triggerer serves exactly the team-less scope, which ``expected`` spells ``None``.
Review Comment:
I don't understand this comment, specifically this part:
> which ``expected`` spells ``None``.
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -273,7 +273,9 @@ def _execute(self) -> int | None:
capacity=self.capacity,
logger=log,
queues=self.queues,
- team_name=self.job.team_name,
+ # A triggerer is started with at most one ``--team-name``, so while a Job can serve
+ # several teams this one never does, and the runner stays scoped to a single team.
+ team_name=next(iter(self.job.team_names), None),
Review Comment:
Might be worth just adding "for now" in there somewhere? There is nothing stopping us from allowing multiple `--team-name` or for that option to take multiple values. I could see users pushing for this so that they don't have to run so many triggerers if they don't care if they execute in the same space (just like we allow teams to share executors if they wish to).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a Job to be associated with several teams [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #73561:
URL: https://github.com/apache/airflow/pull/73561#discussion_r4086474628
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -273,7 +273,9 @@ def _execute(self) -> int | None:
capacity=self.capacity,
logger=log,
queues=self.queues,
- team_name=self.job.team_name,
+ # A triggerer is started with at most one ``--team-name``, so while a Job can serve
+ # several teams this one never does, and the runner stays scoped to a single team.
+ team_name=next(iter(self.job.team_names), None),
Review Comment:
I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org