You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/28 12:01:42 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
tustvold opened a new pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244
# Which issue does this PR close?
Closes #1032
# Rationale for this change
#1134 was a tad overzealous and moved some functionality behind the experimental flags that downstream projects depend on.
# What changes are included in this PR?
* `arrow::schema` is made public, this is used by [IOx](https://github.com/influxdata/influxdb_iox/) to get the arrow schema from parquet metadata cached in its catalog
* `data_type` is made public, this is used by [sqlite2parquet](https://github.com/asayers/sqlite2parquet) in order to interface with the `ColumnWriter` APIs
I debated spending the time to instead mark the various bits of these modules experimental, but since the move to more frequent breaking releases (#1120) there seems to be limited value add from such an undertaking. The concept of experimental made sense when breaking changes were quarterly, now that they're biweekly...
# Are there any user-facing changes?
No breaking changes, this can (and perhaps should be) a patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] pacman82 commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
pacman82 commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024538031
Thanks for merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] pacman82 commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
pacman82 commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024513014
`DataType` is used in `odbc2parquet`, too. I would welcome to have it back in the public API again, or to at least have an alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] pacman82 commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
pacman82 commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024537530
You are welcome @alamb !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024578301
This should be available in arrow 9.0.0 (scheduled for release in ~ Feb 7, 2022) -- I'll make an RC next friday and then it takes 3ish days to get approved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024162244
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1244](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a4469c) into [master](https://codecov.io/gh/apache/arrow-rs/commit/02573e90b622d0ca2b1694d4e8513da638f67f7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02573e9) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1244 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 178 178
Lines 51522 51522
=======================================
+ Hits 42740 42741 +1
+ Misses 8782 8781 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `84.64% <0.00%> (-0.13%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (ø)` | |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.71% <0.00%> (+0.19%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1244/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [02573e9...6a4469c](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024532411
Thank you for the report @pacman82 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1244:
URL: https://github.com/apache/arrow-rs/pull/1244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org