You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/22 20:37:54 UTC

[GitHub] [incubator-nuttx] davids5 commented on pull request #3589: Migrate build system to CMake

davids5 commented on pull request #3589:
URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825168361


   > @antmerlino @davids5 what are your though on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this?
   
   I think we should take it slow to not force the migration on our users base all at once.  
   
   But ultimately NuttX can be a library. We should allow the consuming  project to be able to configure build options. Things like  -Werror etc. There are also some compile time settings that need to be equivalent in both builds. Like `CONFIG_ARMV7M_STACKCHECK` -> drives `FLAGS += -finstrument-functions -ffixed-r10` [see this for example](https://github.com/PX4/PX4-Autopilot/blob/437825418297c1ff43681acc6cf870e2f51d1dcb/platforms/nuttx/NuttX/Make.defs.in#L120) 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org