You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/10/04 18:30:01 UTC
Re: Review Request 71488: Track per-role and per-agent allocated
resources in the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/
-----------------------------------------------------------
(Updated Oct. 4, 2019, 6:30 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Summary (updated)
-----------------
Track per-role and per-agent allocated resources in the allocator.
Bugs: MESOS-9949
https://issues.apache.org/jira/browse/MESOS-9949
Repository: mesos
Description (updated)
-------
This patch adds tracking of per-role allocated resources in the
allocator's roles tree. Also, tracking of per-agent allocated resources
is added to facilitate correct untracking of the role's allocated
resources on agent removal.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
Diff: https://reviews.apache.org/r/71488/diff/5/
Changes: https://reviews.apache.org/r/71488/diff/4-5/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 71488: Track per-role and per-agent allocated
resources in the allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/#review218091
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Oct. 4, 2019, 11:30 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71488/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2019, 11:30 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds tracking of per-role allocated resources in the
> allocator's roles tree. Also, tracking of per-agent allocated resources
> is added to facilitate correct untracking of the role's allocated
> resources on agent removal.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
> src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
>
>
> Diff: https://reviews.apache.org/r/71488/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71488: Track per-role and per-agent allocated
resources in the allocator.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On Oct. 4, 2019, 10:26 p.m., Meng Zhu wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 1534 (patched)
> > <https://reviews.apache.org/r/71488/diff/5/?file=2168125#file2168125line1538>
> >
> > s/allocated/isAllocated/
> >
> > I will take care of this before commit.
Sorry,forgot to publish an update to this patch.
Updated it now
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/#review218094
-----------------------------------------------------------
On Oct. 7, 2019, 7:20 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71488/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2019, 7:20 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds tracking of per-role allocated resources in the
> allocator's roles tree. Also, tracking of per-agent allocated resources
> is added to facilitate correct untracking of the role's allocated
> resources on agent removal.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
> src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
>
>
> Diff: https://reviews.apache.org/r/71488/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71488: Track per-role and per-agent allocated
resources in the allocator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/#review218094
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp
Lines 1534 (patched)
<https://reviews.apache.org/r/71488/#comment305629>
s/allocated/isAllocated/
I will take care of this before commit.
- Meng Zhu
On Oct. 4, 2019, 11:30 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71488/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2019, 11:30 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds tracking of per-role allocated resources in the
> allocator's roles tree. Also, tracking of per-agent allocated resources
> is added to facilitate correct untracking of the role's allocated
> resources on agent removal.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
> src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
>
>
> Diff: https://reviews.apache.org/r/71488/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71488: Track per-role and per-agent allocated
resources in the allocator.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/
-----------------------------------------------------------
(Updated Oct. 7, 2019, 7:20 a.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9949
https://issues.apache.org/jira/browse/MESOS-9949
Repository: mesos
Description
-------
This patch adds tracking of per-role allocated resources in the
allocator's roles tree. Also, tracking of per-agent allocated resources
is added to facilitate correct untracking of the role's allocated
resources on agent removal.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24
src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc
Diff: https://reviews.apache.org/r/71488/diff/6/
Changes: https://reviews.apache.org/r/71488/diff/5-6/
Testing
-------
Thanks,
Andrei Sekretenko