You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "klion26 (via GitHub)" <gi...@apache.org> on 2024/10/28 15:11:22 UTC
[PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
klion26 opened a new pull request, #3304:
URL: https://github.com/apache/amoro/pull/3304
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3303 .
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on code in PR #3304:
URL: https://github.com/apache/amoro/pull/3304#discussion_r1820124542
##########
pom.xml:
##########
@@ -143,6 +143,8 @@
<rocksdb-dependency-scope>compile</rocksdb-dependency-scope>
<lucene-dependency-scope>compile</lucene-dependency-scope>
+
+ <paimon-dependency-scope>compile</paimon-dependency-scope>
Review Comment:
Change to compile because the scope for parent pom is compile, will change to runtime if this is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #3304:
URL: https://github.com/apache/amoro/pull/3304#issuecomment-2445707614
@zhoujinsong thanks for the review and merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on code in PR #3304:
URL: https://github.com/apache/amoro/pull/3304#discussion_r1821707563
##########
amoro-ams/dist/src/main/assemblies/release-bin.xml:
##########
@@ -29,37 +29,37 @@
<files>
<file>
- <source>../amoro-ams/target/amoro-ams-${project.version}.jar</source>
Review Comment:
the new file was copied from bin.xml in 0.7.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #3304:
URL: https://github.com/apache/amoro/pull/3304#discussion_r1820045305
##########
amoro-ams/dist/pom.xml:
##########
@@ -30,6 +30,9 @@
<name>Amoro Project AMS Dist</name>
<url>https://amoro.apache.org</url>
+ <properties>
+ <assembly.descriptor.file>src/main/assemblies/bin.xml</assembly.descriptor.file>
Review Comment:
It seems this PR contains some changes of another PR.
##########
pom.xml:
##########
@@ -143,6 +143,8 @@
<rocksdb-dependency-scope>compile</rocksdb-dependency-scope>
<lucene-dependency-scope>compile</lucene-dependency-scope>
+
+ <paimon-dependency-scope>compile</paimon-dependency-scope>
Review Comment:
Would it be more appropriate to change the default dependency scope to runtime like before?
##########
amoro-core/pom.xml:
##########
@@ -149,6 +149,7 @@
<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
+ <scope>${rocksdb-dependency-scope}</scope>
Review Comment:
I'm not sure if we need to emphasize the scope here. Perhaps it can be inherited directly from the parent?
##########
amoro-ams/amoro-ams-server/pom.xml:
##########
@@ -310,14 +310,14 @@
<dependency>
<groupId>org.apache.paimon</groupId>
<artifactId>paimon-s3</artifactId>
- <scope>runtime</scope>
+ <scope>${paimon-dependency-scope}</scope>
Review Comment:
I'm not sure if we need to emphasize the scope here. Perhaps it can be inherited directly from the parent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on code in PR #3304:
URL: https://github.com/apache/amoro/pull/3304#discussion_r1820126481
##########
amoro-core/pom.xml:
##########
@@ -149,6 +149,7 @@
<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
+ <scope>${rocksdb-dependency-scope}</scope>
Review Comment:
this need to be defined here, otherwise the compile will be failed because of can found rocksdb class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3304:
URL: https://github.com/apache/amoro/pull/3304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org