[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2638: [Engine][PhysicalPlan] Recreate action with parallelism

[GitBox <gi...@apache.org>]

Hisoka-X commented on code in PR #2638:
URL: https://github.com/apache/incubator-seatunnel/pull/2638#discussion_r962276315


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/execution/ExecutionPlanGenerator.java:
##########
@@ -157,7 +157,7 @@ private void createExecutionVertex(LogicalVertex logicalVertex) {
         final long newId = idGenerator.getNextId();
         Action newAction;
         if (chainedVertices.size() < 1) {
-            newAction = recreateAction(logicalVertex.getAction(), newId);
+            newAction = recreateAction(logicalVertex.getAction(), newId, logicalVertex.getParallelism());
         } else {
             List<SeaTunnelTransform> transforms = new ArrayList<>(chainedVertices.size());
             List<String> names = new ArrayList<>(chainedVertices.size());

Review Comment:
   No, this bug only happen when use union feature.



##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/execution/ExecutionPlanGenerator.java:
##########
@@ -157,7 +157,7 @@ private void createExecutionVertex(LogicalVertex logicalVertex) {
         final long newId = idGenerator.getNextId();
         Action newAction;
         if (chainedVertices.size() < 1) {
-            newAction = recreateAction(logicalVertex.getAction(), newId);
+            newAction = recreateAction(logicalVertex.getAction(), newId, logicalVertex.getParallelism());
         } else {
             List<SeaTunnelTransform> transforms = new ArrayList<>(chainedVertices.size());
             List<String> names = new ArrayList<>(chainedVertices.size());

Review Comment:
   No, this bug only happen when use union feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org