You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mbrobbel (via GitHub)" <gi...@apache.org> on 2025/02/05 11:04:31 UTC
[PR] Fix a clippy warning in `datafusion-sqllogictest` [datafusion]
mbrobbel opened a new pull request, #14506:
URL: https://github.com/apache/datafusion/pull/14506
## Which issue does this PR close?
```
❯ cargo clippy -p datafusion-sqllogictest --all-features -- -Dwarnings
Checking datafusion-sqllogictest v45.0.0 (/Users/matthijsbrobbel/code/arrow-datafusion/datafusion/sqllogictest)
error: use of a disallowed method `tokio::task::spawn`
--> datafusion/sqllogictest/src/engines/postgres_engine/mod.rs:93:27
|
93 | let join_handle = tokio::spawn(async move {
| ^^^^^^^^^^^^
|
= note: To provide cancel-safety, use `SpawnedTask::spawn` instead (https://github.com/apache/datafusion/issues/6513)
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods
= note: `-D clippy::disallowed-methods` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::disallowed_methods)]`
error: could not compile `datafusion-sqllogictest` (lib) due to 1 previous error
```
## Rationale for this change
https://github.com/apache/datafusion/pull/14483#discussion_r1942627197
## What changes are included in this PR?
Use `SpawnedTask::spawn` instead of `tokio::task::spawn`.
## Are these changes tested?
CI.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix a clippy warning in `datafusion-sqllogictest` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #14506:
URL: https://github.com/apache/datafusion/pull/14506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org